Skip to content

Commit

Permalink
TODOs for #21
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 12, 2021
1 parent 2b582c1 commit 55afd48
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions js/SpanNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class SpanNode extends LayoutBox {
assert && assert( typeof delta === 'number', 'invalid delta' );
assert && assert( labelNode instanceof Node, 'invalid labelNode' );

//TODO https://github.com/phetsims/bamboo/issues/19 support Orientation.VERTICAL
//TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL
assert && assert( axisOrientation !== Orientation.VERTICAL, 'Orientation.VERTICAL is not yet supported' );

options = merge( {
Expand Down Expand Up @@ -94,7 +94,7 @@ class SpanNode extends LayoutBox {
if ( Math.abs( viewWidth - this.viewWidth ) > notificationThreshold ) {
this.viewWidth = viewWidth;

//TODO https://github.com/phetsims/bamboo/issues/19 arrow code only works for axisOrientation === Orientation.HORIZONTAL
//TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL
//TODO https://github.com/phetsims/bamboo/issues/19 parameterize length of lines at ends of arrow
//TODO https://github.com/phetsims/bamboo/issues/19 parameterize ArrowNode options
// Create double-headed arrow with bars at to show modelDelta
Expand All @@ -113,7 +113,7 @@ class SpanNode extends LayoutBox {
children: [ leftBar, rightBar, arrowNode ]
} );

//TODO https://github.com/phetsims/bamboo/issues/19 maxWidth only works for axisOrientation === Orientation.HORIZONTAL
//TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL
// Prevent labelNode from being wider than arrowWithBars
this.labelNode.maxWidth = arrowWithBars.width;

Expand Down

0 comments on commit 55afd48

Please sign in to comment.