Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative charges in wall are cut off #481

Closed
terracoda opened this issue Feb 8, 2021 · 6 comments
Closed

Negative charges in wall are cut off #481

terracoda opened this issue Feb 8, 2021 · 6 comments
Assignees
Labels

Comments

@terracoda
Copy link
Contributor

This might be a known issue. I just happen to notice this today on master. The negative charges in the published version look fine.
Screen Shot 2021-02-08 at 11 44 30 AM

@emily-phet
Copy link

@terracoda @jessegreenberg I believe this is a known issue. @jbphet has been working on this sim, adding sound, and we noticed this in a sound design meeting. I think @jbphet thinks he may have done this in his work on the sim. You'll probably want to check with him re maintenance release, as he has some things in progress at the moment.

@terracoda
Copy link
Contributor Author

In light of issue phetsims/scenery-phet#490 and the need for maintenance releases for a few sims including this one (BASE), @jbphet can you work with @jessegreenberg to make sure this image problem doesn't end up in the maintenance release.

Maybe the commits for the maintenance release are obvious, and there is no concern.

Assigning the issue to you, @jbphet, just in case.

@terracoda terracoda assigned jbphet and unassigned terracoda and jessegreenberg Feb 15, 2021
@terracoda
Copy link
Contributor Author

terracoda commented Feb 15, 2021

Assign back to me if you need me to verify anything, or if have any questions.

@terracoda
Copy link
Contributor Author

@jbphet, @jessegreenberg said this bug won't be part of the maintenance release needed for phetsims/scenery-phet#490 , so you can deal with this bug as you see fit within your own list of priorities :-)

@jessegreenberg
Copy link
Contributor

Thanks @terracoda @emily-phet, good to know. The maintenance releases for phetsims/scenery-phet#490 will only include the fixing commit for that issue and shouldn't include other breaking changes in master, but we will be sure to check for this before we republish.

From #481 (comment) it sounds like @jbphet may be aware of changes for this issue already so I will leave him assigned, but let me know if I should look into it!

@jbphet
Copy link
Contributor

jbphet commented Feb 16, 2021

This was identified in #482 and has been addressed. It was a Scenery bug, and was not related to any of the work that was being done for sonification. And, for the record, I never thought that it was. Closing.

@jbphet jbphet closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants