Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAWS shifts keyboard navigation focus after picking up balloon #405

Closed
ghost opened this issue May 16, 2018 · 26 comments
Closed

JAWS shifts keyboard navigation focus after picking up balloon #405

ghost opened this issue May 16, 2018 · 26 comments
Labels

Comments

@ghost
Copy link

ghost commented May 16, 2018

Test Device

Hanson

Operating System

Windows 10

Browser

Firefox ESR 52.8.0

Problem Description

For phetsims/qa/issues/112. For some reason, tabbing to the balloon, pressing space, and then pressing A will shift the keyboard navigation focus to the radio buttons for the charge settings. This only occurs when JAWS is running, and doesn't occur when I try to record it. I don't think it's luck, I've tried to record it many times and I even tried a different screen capture software, so I'm not sure what to make of that. Possibly related to #404.

Steps to Reproduce

  1. Have JAWS running.
  2. Tab to balloon.
  3. Press space.
  4. Press A.

Visuals

No visuals. See description of problem.

Troubleshooting Information

Name: ‪Balloons and Static Electricity‬
URL: https://bayes.colorado.edu/dev/html/balloons-and-static-electricity/1.4.0-dev.21/phet/balloons-and-static-electricity_all_phet_debug.html?accessibility
Version: 1.4.0-dev.21 2018-04-04 18:25:56 UTC
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Language: en-US
Window: 1280x611
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0
GLSL: WebGL GLSL ES 1.0
Vendor: Mozilla (Mozilla)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"928741cf","branch":"master"},"axon":{"sha":"ceb3cc00","branch":"master"},"balloons-and-static-electricity":{"sha":"f4f3cc64","branch":"master"},"brand":{"sha":"89d28f63","branch":"master"},"chipper":{"sha":"bc7c5d1f","branch":"master"},"dot":{"sha":"e5489d18","branch":"master"},"joist":{"sha":"2cf256a9","branch":"master"},"kite":{"sha":"b6071478","branch":"master"},"phet-core":{"sha":"d8804eee","branch":"master"},"phet-io":{"sha":"4bbddfaa","branch":"master"},"phet-io-website":{"sha":"b6c2b0f5","branch":"master"},"phet-io-wrapper-classroom-activity":{"sha":"1ecd81a1","branch":"master"},"phet-io-wrapper-lab-book":{"sha":"b1c5562c","branch":"master"},"phet-io-wrappers":{"sha":"025cc23d","branch":"master"},"phetcommon":{"sha":"de004c6e","branch":"master"},"query-string-machine":{"sha":"c379f1db","branch":"master"},"scenery":{"sha":"4a4afee2","branch":"master"},"scenery-phet":{"sha":"e68ebc03","branch":"master"},"sherpa":{"sha":"bb14a03a","branch":"master"},"sun":{"sha":"8a187c9f","branch":"master"},"tandem":{"sha":"f8147666","branch":"master"},"vibe":{"sha":"2dc20be7","branch":"master"}}

@jessegreenberg
Copy link
Contributor

Very weird that it only happens when not recording. 'A' is the JAWS hotkey to go to radio button groups so that much makes sense. What does not make sense is that JAWS is ignoring role=application. @lmulhall-phet are you able to use WASD keys at all with JAWS? Is this a problem only when using spacebar?

@terracoda
Copy link
Contributor

@lmulhall-phet, do you have forms mode set to auto? I think that is the default setting, but I am not sure?

If JAWS is not going into forms mode automatically, it is possible that only the Enter key will force it into forms mode.

Does the balloon get grabbed if you press Enter twice then press A key, or press Enter then Space then A key?

At any point do you hear the JAWS-entered-forms-mode pop sound?

@terracoda
Copy link
Contributor

Oh, and to clarify this only happens with Space key? Then maybe doubling up the interaction is not very useful?

@terracoda
Copy link
Contributor

terracoda commented May 16, 2018

Oh, I just found this document on JAWS and forms mode:
http://www.freedomscientific.com/Content/Documents/Other/JAWS-ARIA-Support.doc

Could this section be the issue?

Different Control Types
In terms of Forms Mode, there are two groups of controls: those that require Forms Mode to interact with them, and those controls that never require Forms Mode to interact with them.
Forms Mode is required for edit fields, combo boxes, spin controls, list controls, tab controls, menu bars, tree views, and grid cells. For these controls, press ENTER or SPACEBAR to enter Forms Mode, and ESC or NUM PAD PLUS to exit Forms Mode.
For buttons and check boxes, use ENTER or SPACEBAR to activate the control at the location of the Virtual Cursor. Users interact with these controls simply by pressing ENTER or SPACEBAR; so forms mode is unnecessary. Auto Forms Mode causes JAWS to leave Forms Mode when it encounters these control types because they are just as usable without Forms Mode.

@terracoda
Copy link
Contributor

terracoda commented May 16, 2018

It should NOT (added) matter whether one is in forms mode or not when on a button, but maybe it does (edited) here?

@terracoda
Copy link
Contributor

@lmulhall-phet for comparison and understanding can you test with auto-forms mode set to off, and see how that affects the interaction?

@jessegreenberg
Copy link
Contributor

It seems to me like it shouldn't matter, focus is on the div with role=application.

@terracoda
Copy link
Contributor

@jessegreenberg, my understanding was that perhaps JAWS was not entering application role (aka forms mode) from the button??

@ghost
Copy link
Author

ghost commented May 16, 2018

@terracoda @jessegreenberg I'll test forms mode to verify.

@jessegreenberg
Copy link
Contributor

Perhaps, but I think @lmulhall-phet said he could use the WASD keys sometimes with JAWS. My interpretation of the section you posted is for the active element, not the previous element that had focus.

@ghost
Copy link
Author

ghost commented May 16, 2018

I'm not experiencing this issue in FF 60.

@jessegreenberg
Copy link
Contributor

Thanks @lmulhall-phet, good to know.

@ghost
Copy link
Author

ghost commented May 16, 2018

@terracoda @jessegreenberg this happens with the enter key as well. I don't hear the pop sound when pressing space or enter.

@ghost
Copy link
Author

ghost commented May 16, 2018

@jessegreenberg still occurs when I wait for the dialogue to complete.

@jessegreenberg
Copy link
Contributor

@lmulhall-phet when using JAWS, have you ever heard it say "Forms mode on"?

@ghost
Copy link
Author

ghost commented May 16, 2018

@jessegreenberg, no I haven't.

@terracoda
Copy link
Contributor

@jessegreenberg and @lmulhall-phet, my understanding and experience is that JAWS makes a pop sound when it enters forms mode. I have heard this sound many times during interviews. I don't know if this pop sound is turned on through a user setting.

@terracoda
Copy link
Contributor

@lmulhall-phet, just for clarification, you tab to the Grab balloon button, you hit Enter or Space keys, and in both cases you do not hear a pop, then you Press A and go to the radio buttons.

Is that correct?

@terracoda
Copy link
Contributor

And at any time after hitting Enter or Space on the grab button, do you hear, "Grabbed. At center of play area..."?

@jessegreenberg
Copy link
Contributor

my understanding and experience is that JAWS makes a pop sound when it enters forms mode.

Interesting, probably a user setting then. My version definitely says "Forms mode on" and "Forms mode off" when it toggles.

@terracoda
Copy link
Contributor

Makes sense why I hear the pop in interviews with screen reader users then. Seems like a good setting to change. I'd rather hear a pop than "forms mode on/off" every time I entered forms mode.

@ghost
Copy link
Author

ghost commented May 17, 2018

@jessegreenberg I'm experiencing the keyboard navigation focus shifting phenomenon with the Reset Balloon button as well on FF 60.0.1.

@ghost
Copy link
Author

ghost commented May 17, 2018

Here are the details for keyboard navigation focus shifting in FF 60.0.1 (with JAWS, of course):

Balloon

  • space: no
  • enter: no

Remove Wall

  • space: yes
  • enter: yes

Balloon Checkbox

  • space: yes
  • enter: yes

Reset Balloon

  • space: yes
  • enter: yes

Charge Settings Radio Buttons

  • space: no
  • enter: no

Reset All

  • space: yes
  • enter: yes

Keyboard Shortcuts

  • space: no
  • enter: no

PhET Menu

  • space: no
  • enter: no

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 18, 2018

@lmulhall-phet was #405 (comment) comment meant for this issue or #404?

@jessegreenberg
Copy link
Contributor

I am not able to reproduce the original issue

For some reason, tabbing to the balloon, pressing space, and then pressing A will shift the keyboard navigation focus to the radio buttons for the charge settings.

in FF 60. @lmulhall-phet I think you said that as well in #405 (comment).

If we proceed with supporting FF 60, can this issue be closed?

@jessegreenberg jessegreenberg assigned ghost and unassigned terracoda and jessegreenberg May 18, 2018
@jessegreenberg jessegreenberg changed the title JAWS shifts keyboard navigation focus JAWS shifts keyboard navigation focus after picking up balloon May 18, 2018
@ghost
Copy link
Author

ghost commented May 18, 2018

@lmulhall-phet was #405 (comment) comment meant for this issue or #404?

I agree #404 would have been a more appropriate place to post that comment.

can this issue be closed?

@jessegreenberg I haven't been able to reproduce the original issue either, so yes.

@ghost ghost closed this as completed May 18, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants