-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature requests and changes #120
Comments
@jessegreenberg, does #120 make sense? I don't know how to label it as an a11y issue. |
Thanks @terracoda, this all makes sense. I will work on all of this before the next dev version. Just to double check on the changes regarding the The current header looks like this: <header role="banner" aria-labelledby="scene-label-14-35" aria-describedby="scene-descripion-14-35">
<h1 id="scene-label-14-35">The scene for Balloons and Static Electricity</h1>
<div id="scene-descripion-14-35">
<p>A balloon floats evenly between a large woolly sweater and a removable wall. The sweater is to the left and the wall is to the right. Each object shows negative and positive charges. Charges are shown in pairs. Currently, the sweater and the wall have many pairs of charges, the balloon, just a few. The control panel has controls to add a second balloon, adjust charge views and to reset the entire experiment. Select Tab for next item. Select K or question mark for keyboard help. Select H for a heading outline.</p>
</div>
</header> If I understand correctly, it should look something like this: <header role="banner" aria-labelledby="scene-label-14-35" aria-describedby="scene-descripion-14-35">
<h1 id="scene-label-14-35">Balloons and Static Electricity</h1>
</header>
<div class="ScreenViewContainer" role="main">
<div id="scene-description-id">
<h2 id='scene-description-label-id'>The scene for Balloons and Static Electricity</h2>
<p>This simulation contains a Play Area and a Control Panel. The Play Area is a room. It has a balloon, a sweater and a wall. The Control Panel allows you to add a balloon, remove the wall and reset the entire experiment. Currently, the sweater and wall have many pairs of charges, the balloon, just a few. Balloon is in middle of Play Area, evenly placed between sweater and wall. Tab to navigate between objects. Press question mark for keyboard commands and help.</p>
</div>
<section id="play-area-14-35-37" aria-labelledby="heading-node-36">
....
</section>
<section id="control-panel-14-35-58" aria-labelledby="heading-node-xx">
.........
</section> Is this structure change correct? |
In addition to the above feature list, I would like to investigate another issue
|
@jessegreenberg regarding structure, we won't need an aria-describedby attribute any more for the <header role="banner">
<h1 id="scene-label-14-35">Balloons and Static Electricity</h1>
</header>
<main class="ScreenViewContainer" role="main">
<section id="scene-description-id">
<h2 id='scene-description-label-id'>Scene Summary</h2>
<p>This simulation contains a Play Area and a Control Panel. The Play Area is a room. It has a balloon, a sweater and a wall. The Control Panel allows you to add a balloon, remove the wall and reset the entire experiment. Currently, the sweater and wall have many pairs of charges, the balloon, just a few. Balloon is in middle of Play Area, evenly placed between sweater and wall. Tab to navigate between objects. Press question mark for keyboard commands and help.</p>
</section>
<section id="play-area-14-35-37" aria-labelledby="heading-node-36">
....
</section>
<section id="control-panel-14-35-58" aria-labelledby="heading-node-xx">
.........
</section>
</main> |
@jessegreenberg if I find (or remember) more items, should I create new issues or add to the check list? |
@jessegreenberg thanks for adding the issue from the testing document 'A11y Balloons: Testing Inst. 9'. |
@jessegreenberg I realize now, you won't be able to check off the issues list. I will changed my check boxes to a normal list. I suppose you'll have to make a checkbox comment to which you have access. |
@jessegreenberg I'm working in the google sheet BASE Labels & Descriptions. I'll try to keep an eye this issue page in case you have questions. |
@terracoda, thank you for clarifying, and pasting an example of the html. I like the idea of the description being in its own section. I had initially avoided using the
I will change the div to a |
@terracoda, this seems like a good place to document changes for the next dev version. Please add any new change items to the list in this issue. |
I changed the issue list to a checkbox list, just so that it is easier to track the status of this issue. Hope that is OK! |
|
@jessegreenberg Re checkbox list - Awesome. I didn't realize you would have access to check things off. That's perfect. I will add issues to list above as I come across them. |
@jessegreenberg In the Scene Summary description above in the issue list, I put double square brackets around content that is dynamic. Hopefully, these strings will fit perfectly with the other strings, so things stay grammatical as they update (eventually update). I might have to tweak the sentences, so we can reduce the number of custom strings. |
@terracoda, where should this description be located? Is this part of the balloon description? |
@jessegreenberg Yes, the WASD key navigation cue is read out at the end of the balloon description, upon focus. Sorry the full navigation cue is Use WASD keys to grab and drag balloon up, left, down and right. Tab for next object. Press question mark for keyboard commands and help. |
Description for the scene summary has been changed, but it is not dynamic yet. Making it dynamic will take a fair amount of time and further discussion. |
Ok, thanks @terracoda. I updated the navigation cue for the balloon. |
New dev version deployed: The aria-live update for the ABSwitch only seems to work for NVDA + Firefox and JAWS + IE. Other browsers do not receive any dynamic description for these. |
I was not able to reproduce this with JAWS 17. We will have to keep watching for this issue. |
@jessegreenberg, ok, I will test new sim on my available systems tomorrow. |
Since all items have been addressed, closing this issue. New items will be added to new issues or version reviews. |
@jessegreenberg thanks :-) |
Some Issues from Interviews 3 and 4:
main
region, and have anh2
. Theh1
in theheader
element now change to be the same as the sim/page title: Balloons and Static Electricity.aria-describedby
attributes on Wall button, Sim Reset button and Balloons A-B switch. Leave the description on the Balloon Reset button for now.Tab to navigate to next object. Press question mark for keyboard commands and help.
The text was updated successfully, but these errors were encountered: