Skip to content

Commit

Permalink
incorporated correct wall-contact sound, see #479
Browse files Browse the repository at this point in the history
  • Loading branch information
jbphet committed Feb 24, 2021
1 parent 5e10a10 commit 87fa8ec
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
7 changes: 1 addition & 6 deletions js/balloons-and-static-electricity/view/BalloonNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,15 +260,10 @@ class BalloonNode extends Node {
balloonHitsSweaterSoundClip.play();
}
} );
// model.onSweaterProperty.link( onSweater => {
// if ( onSweater && !model.isDraggedProperty.value ) {
// balloonHitsSweaterSoundClip.play();
// }
// } );

// sound generation for when the balloon hits the wall
const balloonHitsWallSoundClip = new SoundClip( balloonHitsWallSound, {
initialOutputLevel: 0.2
initialOutputLevel: 0.6
} );
soundManager.addSoundGenerator( balloonHitsWallSoundClip );
model.touchingWallProperty.link( touchingWall => {
Expand Down
2 changes: 1 addition & 1 deletion sounds/license.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Mike Winters for use by PhET"
"notes": "created by Mike Winters for use by PhET, formerly called Boundary2_thud_short.mp3"
}
}
Binary file modified sounds/wall-contact.mp3
Binary file not shown.
Loading

0 comments on commit 87fa8ec

Please sign in to comment.