-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does Equation needs a dispose method? #142
Comments
Equation does not currently need this.reactants.forEach( reactant => reactant.userCoefficientProperty.lazyLink( observer ) );
this.products.forEach( product => product.userCoefficientProperty.lazyLink( observer ) ); ... but Equation is an abstract base class, and the reactants and products are own owned by the subclasses. So there is no need to call dispose for any instance of Equation. It will likely need |
I detected a TODO for this issue as part of phetsims/chipper#946 and decided to remove the TODO. |
Game creates 5 of these when level selection button is pressed.
The text was updated successfully, but these errors were encountered: