Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to new Region and Culture approach #155

Closed
Luisav1 opened this issue Mar 25, 2024 · 4 comments
Closed

Convert to new Region and Culture approach #155

Luisav1 opened this issue Mar 25, 2024 · 4 comments
Assignees
@Luisav1
Labels
status:ready-for-review

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Mar 25, 2024

From phetsims/joist#958, to convert Balancing Act to use the new localizedImageProperty.
@Luisav1 Luisav1 self-assigned this Mar 25, 2024
Luisav1 added a commit that referenced this issue Mar 25, 2024
@Luisav1
Rename images from {{region}}LabIcon -> {{region}}LabScreenIcon. See #…
612199e 
…155.
@Luisav1 Luisav1 mentioned this issue Mar 25, 2024
Closed
7 tasks
Luisav1 added a commit that referenced this issue Mar 25, 2024
@Luisav1
Create BalancingActImages.ts and use lab screen icon image there, del…
34a0091 
…ete BalanceLabScreenIcon.js. See #155.
Luisav1 added a commit that referenced this issue Mar 25, 2024
@Luisav1
Use localized images in HumanTypeEnum.js. Delete unused PreferencesMo…
34f1523 
…delSingleton.js. See #155.
@Luisav1
Copy link
Contributor Author

Luisav1 commented Mar 25, 2024

The conversion is done, no issues came up during it. This is ready for your review @pixelzoom.

@Luisav1 Luisav1 assigned pixelzoom and unassigned Luisav1 Mar 25, 2024
@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 1, 2024 •
edited
Loading

I looked over the commits, and didn't see any issues -- this all looks very nice. Since @Luisav1 indicated this is done, I'll go ahead and close this issue.

pixelzoom added a commit that referenced this issue Apr 1, 2024
@pixelzoom
delete vestigial files, #155
034b6cf
@pixelzoom
Copy link
Contributor

Oops, reopening. It looks like you missed some vestigial files -- BalancerImages, BalancerPortrayal, etc. I delete them in the above commit.

Back to @Luisav1 to review, in case there are any other vestigial files that I'm not aware of. Feel free to close.

@pixelzoom pixelzoom reopened this Apr 1, 2024
@pixelzoom pixelzoom assigned Luisav1 and unassigned pixelzoom Apr 1, 2024
@Luisav1
Copy link
Contributor Author

Luisav1 commented Apr 2, 2024

Oops, sorry for missing those files! Thanks for catching it. Reviewed and don't see any other files left. Closing.

@Luisav1 Luisav1 closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @Luisav1