Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sim-specific code with LevelSelectionButtonGroup #135

Closed
pixelzoom opened this issue Oct 6, 2022 · 4 comments
Closed

Replace sim-specific code with LevelSelectionButtonGroup #135

pixelzoom opened this issue Oct 6, 2022 · 4 comments
Assignees
@AgustinVallejo @marlitas
Labels
status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to phetsims/vegas#108 ...

LevelSelectionButtonGroup is a new vegas UI component for creating the level-selection buttons for games. It replaces boilerplate code in sims, and provides a consistent PhET-iO tandem structure. Please convert this sim to use LevelSelectionButtonGroup.
@pixelzoom pixelzoom mentioned this issue Oct 6, 2022
Closed
@jbphet
Copy link
Contributor

jbphet commented Oct 10, 2022

Deferring this until the next time this sim needs to be published from master. At that point, this issue should be un-deferred and addressed.

@marlitas
Copy link
Contributor

We can do this now! Assigning to @Luisav1 since she's a pro at this now.

@marlitas marlitas assigned Luisav1 and unassigned jbphet Nov 30, 2023
@marlitas marlitas mentioned this issue Nov 30, 2023
Closed
Luisav1 added a commit that referenced this issue Dec 8, 2023
@Luisav1
Use LevelSelectionButtonGroup to make level selection buttons in game…
6040d92 
… screen. See #135.
@Luisav1
Copy link
Contributor

Luisav1 commented Dec 8, 2023

This sim now uses the LevelSelectionButtonGroup to arrange the buttons but since that arranges the buttons placement itself, the layout did shift ever so slightly. For that reason I'd like @marlitas or @AgustinVallejo to review to ensure it's alright, thanks.

@Luisav1 Luisav1 assigned AgustinVallejo and marlitas and unassigned Luisav1 Dec 8, 2023
@AgustinVallejo
Copy link
Contributor

Looking good! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

@marlitas marlitas

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pixelzoom @jbphet @AgustinVallejo @marlitas @Luisav1