Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to turn off UI sounds on next publication #133

Closed
markgammon opened this issue Nov 19, 2021 · 4 comments
Closed

Decide whether to turn off UI sounds on next publication #133

markgammon opened this issue Nov 19, 2021 · 4 comments

Comments

@markgammon
Copy link

As part of the work done for phetsims/vegas#77, UI sounds got turned on for this simulation. Before the sim is published again from master, we should decide whether to turn the UI sounds off, leave them on and design and implement sounds for the rest of the interactions, or publish with a partial sound design.

If the decision is to turn them off, this can be accomplished by adding the following line to the end of the sim's -main.js file:

  soundManager.setOutputLevelForCategory( 'user-interface', 0 );
@marlitas
Copy link
Contributor

This also came up in a couple of other sims in the region and culture work. We should have a conversation about sound for those sims in general.

@amanda-phet
Copy link
Contributor

Discussed 12/7/23 and this sim should have sound design for the interaction of picking up and placing objects along the "number line" of the plank if we want to have UI sounds on.

Just keep the game feedback sounds for now.

As a side note, the "number line" sounds in Center and Variability could work well here!

@AgustinVallejo
Copy link
Contributor

The above commit disables standard UI sounds, and keeps the game sounds in place. Please make sure this is what was sought after.

Assigning back to @amanda-phet and @marlitas. Whoever reviews first can close this issue, if ready.

@marlitas
Copy link
Contributor

That sounds like what I would expect if we're only turning game sounds on so I think it's good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants