Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abswitch and onoffswitch have odd names/nesting #101

Closed
samreid opened this issue Jan 20, 2020 · 3 comments
Closed

abswitch and onoffswitch have odd names/nesting #101

samreid opened this issue Jan 20, 2020 · 3 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jan 20, 2020

From #96, @kathy-phet pointed out:

we should work on a few name improvements. "abswitch" is not so friendly. It's also a bit odd that there is a double layer there - with abswitch and then onoffswitch both meaning the same thing. I realize one is the images and one is the toggle. Working on the names would help.

@samreid samreid self-assigned this Jan 20, 2020
@samreid
Copy link
Member Author

samreid commented Jan 29, 2020

In discussion with @kathy-phet, we think it is best to provide the specific contextualized names for the columnSwitch (instead of abSwitch), but we will keep aInputListener as it is, because there is already sufficient context around the model Property change, and we don't want to provide too flexible a schema for sun components.

@samreid
Copy link
Member Author

samreid commented Jan 29, 2020

In the future, we may want to change the onOffSwitch to be better named. But that shouldn't be done before RC1.

@chrisklus
Copy link
Contributor

For now, we renamed abSwitch to columnSwitch. Closing - remaining work related to this discussion over in phetsims/sun#559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants