Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyIO should call to ReadOnlyProperty.toStateObject() #454

Closed
zepumph opened this issue Jun 10, 2024 · 2 comments
Closed

PropertyIO should call to ReadOnlyProperty.toStateObject() #454

zepumph opened this issue Jun 10, 2024 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Jun 10, 2024

This refactor will help with https://github.com/phetsims/phet-io/issues/1881#issuecomment-2155615116. Over there, we would like to hide an implementation detail for the serialization of a subtype of Property, but don't need to (or want to) change the PhET-iO api. Allowing the instance method toStateObject to be overridden will help us do this.
@zepumph zepumph self-assigned this Jun 10, 2024
zepumph added a commit that referenced this issue Jun 11, 2024
@zepumph
move PropertyIO serialization methods into ReadOnlyProperty, #454
1429548 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Jun 11, 2024

phetsims/joist#970

@zepumph
Copy link
Member Author

zepumph commented Jun 12, 2024

Looks good and we are MRing to hydrogen sims for phetsims/joist#970. Closing

@zepumph zepumph closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph