Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are we setting validValues in ReadOnlyProperty.applyState()? #453

Closed
zepumph opened this issue Jun 10, 2024 · 2 comments
Closed

Why are we setting validValues in ReadOnlyProperty.applyState()? #453

zepumph opened this issue Jun 10, 2024 · 2 comments
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Jun 10, 2024

No description provided.

@zepumph zepumph self-assigned this Jun 10, 2024
@zepumph
Copy link
Member Author

zepumph commented Jun 11, 2024

phetsims/joist#970

@zepumph
Copy link
Member Author

zepumph commented Jun 17, 2024

Fixed above. Tested with state wrappers manual testing, and looking for usages of validValues in studio/ and phet-io-wrappers/.

@zepumph zepumph closed this as completed Jun 17, 2024
zepumph added a commit that referenced this issue Jun 17, 2024
@zepumph
validValues should not be PhET-iO state settable for Properties, #453
950e371 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/joist that referenced this issue Jun 17, 2024
@zepumph
validValues should not be PhET-iO state settable for Properties, phet…
5d3f17d 
…sims/axon#453

Signed-off-by: Michael Kauzmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph