Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyForwardingProperty should be able to forward to another TinyProperty #337

Closed
samreid opened this issue Oct 9, 2020 · 4 comments
Closed

TinyForwardingProperty should be able to forward to another TinyProperty #337

samreid opened this issue Oct 9, 2020 · 4 comments
Assignees
@zepumph
Labels
type:misc

Comments

@samreid
Copy link
Member

samreid commented Oct 9, 2020

Currently we only have support for TinyForwardingProperty to forward to Property. It seems to be more general and defensive, it should support being able to forward to TinyProperty as well.

One step will be to add isPhetioInstrumented() to TinyProperty, but we should be more thorough and add tests, etc to move forward on this.
@zepumph
Copy link
Member

zepumph commented Oct 9, 2020

We seem to already support this, because there is a usage in master of passing one Node's visibleProperty to another Node as visibleProperty:

https://github.com/phetsims/wave-on-a-string/blob/120be3a51b535f00692a82867119c06dfac73076/js/wave-on-a-string/view/BottomControlPanel.js#L133-L132

I think we should add tests for this issue.

@zepumph
Copy link
Member

zepumph commented Oct 9, 2020

See phetsims/scenery#1046

zepumph added a commit that referenced this issue Oct 9, 2020
@zepumph
add isPhetioInstrumented to Property interface, #337
70b86f2
@zepumph
Copy link
Member

zepumph commented Oct 9, 2020

All that is left is tests.

zepumph added a commit that referenced this issue Jul 2, 2021
@zepumph
add tests to forward to TinyProperty, #337
89654dd
@zepumph
Copy link
Member

zepumph commented Jul 2, 2021

Looks all set to me. Closing

@zepumph zepumph closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
type:misc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph