Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce tandem.name.endsWith( 'Property' ) in Property constructor #322

Closed
pixelzoom opened this issue Aug 13, 2020 · 3 comments
Closed

enforce tandem.name.endsWith( 'Property' ) in Property constructor #322

pixelzoom opened this issue Aug 13, 2020 · 3 comments
Assignees
@zepumph
Labels
dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

Property currently requires that tandem.name.endsWith( 'Property' ). @zepumph and I expected to find this enforced in the constructor. Instead its in PropertyIO. It should be moved to Property
@zepumph
Copy link
Member

zepumph commented Aug 14, 2020

Tagging parent issue; phetsims/sun#615

zepumph added a commit that referenced this issue Aug 14, 2020
@zepumph
move tandem naming assertion to Property constructor, #322
c9a14b2
zepumph added a commit that referenced this issue Aug 14, 2020
@zepumph
use phetioID in message, #322 phetsims/sun#615
96dce78
zepumph added a commit to phetsims/sun that referenced this issue Aug 14, 2020
@zepumph
use phetioID in message, phetsims/axon#322 #615
430958c
@zepumph
Copy link
Member

zepumph commented Aug 14, 2020

Done above, in the same style as work in phetsims/sun#615 for RadioButtons and ComboBoxListItem.

Aqua fuzzing in phet and phet-io brand is clear. Closing

@zepumph zepumph closed this as completed Aug 14, 2020
@zepumph zepumph mentioned this issue Aug 14, 2020
Closed
@pixelzoom pixelzoom mentioned this issue Aug 15, 2020
Closed
@pixelzoom
Copy link
Contributor Author

Aqua fuzzing in phet and phet-io brand is clear. Closing

I'm not sure how aqua missed it, but normal-modes is failing. See phetsims/normal-modes#55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph