Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert emit1, emit2, emit3 to emit #211

Closed
samreid opened this issue Jan 16, 2019 · 2 comments
Closed

Convert emit1, emit2, emit3 to emit #211

samreid opened this issue Jan 16, 2019 · 2 comments
Assignees
@samreid
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Jan 16, 2019 •
edited
Loading

From #182 @zepumph @chrisklus and noted we need to iterate through all usages of emit1, emit2 and emit3 and convert them to use emit. This will require adding argumentTypes or equivalent (may be renamed soon in #212). This should be done after #204 is complete, since it could change the API.
samreid added a commit that referenced this issue Feb 8, 2019
@samreid
Call emit from emit1, emit2, emit3, see #211
880b311
@samreid samreid mentioned this issue Feb 8, 2019
Closed
samreid added a commit that referenced this issue Feb 8, 2019
@samreid
Updated docs, see #211
57b10ae
@pixelzoom pixelzoom mentioned this issue Feb 9, 2019
Closed
zepumph added a commit to phetsims/equality-explorer that referenced this issue Feb 27, 2019
@zepumph
remove emit3(), use emit() instead, phetsims/axon#204 phetsims/axon#211
2242993
zepumph added a commit that referenced this issue Feb 27, 2019
@zepumph
remove emit3(), use emit() instead, #204 #211
439613c
zepumph added a commit to phetsims/forces-and-motion-basics that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
47bb7e5
zepumph added a commit to phetsims/rutherford-scattering that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
5ad8d60
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
aac22fe
zepumph added a commit to phetsims/gravity-and-orbits that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
f9ce37e
zepumph added a commit to phetsims/pendulum-lab that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
fecb3e5
zepumph added a commit that referenced this issue Feb 27, 2019
@zepumph
remove emit2(), use emit() instead, #204 #211
3bd203e
@samreid samreid mentioned this issue Feb 27, 2019
Closed
23 tasks
zepumph added a commit to phetsims/circuit-construction-kit-common that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
6b58329
zepumph added a commit to phetsims/forces-and-motion-basics that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
0278515
zepumph added a commit to phetsims/rutherford-scattering that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
6ab6853
zepumph added a commit to phetsims/capacitor-lab-basics that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
149bf9e
zepumph added a commit to phetsims/expression-exchange that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
2439e98
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
a7197df
zepumph added a commit to phetsims/masses-and-springs that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
1621f69
zepumph added a commit to phetsims/plinko-probability that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
c862cff
zepumph added a commit to phetsims/gravity-and-orbits that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
0050f4b
zepumph added a commit to phetsims/equality-explorer that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
2eeedcf
zepumph added a commit to phetsims/build-a-molecule that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
81f83e0
zepumph added a commit to phetsims/function-builder that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
9b98f6b
zepumph added a commit to phetsims/build-an-atom that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
df22edb
zepumph added a commit to phetsims/pendulum-lab that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
ca1282b
zepumph added a commit to phetsims/scenery-phet that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
d2ae7eb
zepumph added a commit to phetsims/unit-rates that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
f694e65
zepumph added a commit to phetsims/make-a-ten that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
b5cdac1
zepumph added a commit to phetsims/scenery that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
af9b14e
zepumph added a commit to phetsims/griddle that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
5fe5d96
zepumph added a commit to phetsims/joist that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
a7080dd
zepumph added a commit that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, #211
b0d4cc7
zepumph added a commit to phetsims/sun that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
72268c3
@zepumph
Copy link
Member

zepumph commented Feb 27, 2019

All usages of emit1, emit2, and emit3 have been removed. we used the validationEnabled option to bypass validation in almost all instances (some easy ones were converted as I went). See #227 for steps to remove that option.

There are no longer deprecated emit methods in Emitter. @samreid please review.

zepumph added a commit to phetsims/tambo that referenced this issue Feb 27, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
b7a7db0
@samreid
Copy link
Member Author

samreid commented Mar 6, 2019

I reviewed Emitter and spot checked a few sim commits, it all looks great. Thanks @zepumph. This issue seems good to close and we will continue in #227

@samreid samreid closed this as completed Mar 6, 2019
zepumph added a commit to phetsims/utterance-queue that referenced this issue Oct 22, 2019
@zepumph
remove emit1(), use emit() instead, phetsims/axon#211
90b37e2
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@zepumph @jessegreenberg
remove emit2(), use emit() instead, phetsims/axon#204 phetsims/axon#211
c143c75
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@zepumph @jessegreenberg
remove emit1(), use emit() instead, phetsims/axon#211
4e9e9a3
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
@zepumph @chrisklus
remove emit1(), use emit() instead, phetsims/axon#211
21b7ca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @chrisklus @zepumph