Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilink caches stale values #210

Closed
samreid opened this issue Jan 9, 2019 · 2 comments
Closed

Multilink caches stale values #210

samreid opened this issue Jan 9, 2019 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Jan 9, 2019

Related to #141 and https://github.com/phetsims/phet-io-wrappers/issues/229 and #209

Today @zepumph and @chrisklus and I identified that Multilink is caching stale values, and those values are being used in callbacks. This used to be a problem with DerivedProperty as well, which was corrected in #146. We would like to use the same strategy for Multilink.
chrisklus added a commit that referenced this issue Jan 9, 2019
@chrisklus
Dynamically load values instead of caching, see #210
5803749
@zepumph
Copy link
Member

zepumph commented Jan 11, 2019

@pixelzoom could you please review this issue as it relates to how we get dependency values in DerivedProperty. Anything amiss here?

@zepumph zepumph assigned pixelzoom and unassigned chrisklus Jan 11, 2019
@pixelzoom
Copy link
Contributor

I don't see anything amiss in 5803749. Looks like a worthwhile change.

@pixelzoom pixelzoom assigned zepumph and unassigned pixelzoom Jan 11, 2019
@zepumph zepumph closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @pixelzoom @chrisklus @zepumph