Skip to content

Commit

Permalink
Add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Sep 13, 2019
1 parent 14114d4 commit 42e091a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions js/ObservableArray.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ define( function( require ) {
* @public
*/
pop: function() {

// TODO: should we really pop if the length was 0? Or maybe this is OK?
var item = this._array.pop();
if ( item !== undefined ) {
this.lengthProperty.set( this._array.length );
Expand Down

0 comments on commit 42e091a

Please sign in to comment.