Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Africa/ Modest, Asia, Latin America, and Oceania character sets #198

Closed
marlitas opened this issue Nov 16, 2023 · 7 comments
Closed

Comments

@marlitas
Copy link
Contributor

This sim needs the initial structure to change character sets based on the region and culture preference.

@amanda-phet
Copy link
Contributor

The original artwork is fairly high-res. It's also mipmaps. Can we discuss the ideal size to export this artwork at?

@amanda-phet amanda-phet self-assigned this Dec 1, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
#198

missing levels should come from Africa
amanda-phet added a commit that referenced this issue Dec 5, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
#198

Missing levels should come from Asia
@amanda-phet
Copy link
Contributor

Character sets are uploaded!

The missing levels for Africa-Conservative should come from Africa, and the missing levels for Oceania should come from Asia.

@amanda-phet amanda-phet removed their assignment Dec 5, 2023
amanda-phet added a commit that referenced this issue Dec 5, 2023
marlitas added a commit that referenced this issue Dec 5, 2023
@Luisav1
Copy link
Contributor

Luisav1 commented Dec 6, 2023

All the character sets are loaded in now. @amanda-phet could you review to ensure it's all looking good? Thanks!

@amanda-phet
Copy link
Contributor

  1. There are a few PNGs I would like to update and will upload those today.

  2. The layout of the screen looks really odd- the text is lower and the buttons are smaller. I am mainly concerned about the interference of the text and buttons.

Original:
image

Current:
image

  1. I'm also wondering if this sim should have a "multicultural" random option, since the USA version is all the same person. Can we randomly select from a different region for each screen?

@marlitas
Copy link
Contributor Author

marlitas commented Dec 6, 2023

Yeah that layout is an outstanding issue involving the LevelSelectionButtons. JO, CM, and I are meeting today and may have a solution, but I have a feeling the final solution will be during the LevelSelection design meeting next week.

amanda-phet added a commit that referenced this issue Dec 6, 2023
@amanda-phet
Copy link
Contributor

The SVGs are looking good to me and "multicultural" is working as expected.

@amanda-phet amanda-phet assigned Luisav1 and unassigned amanda-phet Dec 14, 2023
@Luisav1
Copy link
Contributor

Luisav1 commented Dec 14, 2023

Closing since the artwork is looking good. The layout issue with the texts being close to the buttons is being tracked here phetsims/vegas#120.

@Luisav1 Luisav1 closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants