-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to new Region and Culture approach #16
Comments
I'm unsure whether to use generic or specific names for image files. Initially, I opted for |
Wow. The classing naming (and documentation) in area-model-common sure is confusing. There are bigger problems here than the image filenames. So I recommend that you just use the existing image filenames, and not try to sort out the naming problem. I wasn't sure if the R&C conversion was ready for review yet, so I didn't take a look. Feel free to assign back to me for review when you're done. |
…GameHomeScreenIcon. See phetsims/area-model-multiplication#16." This reverts commit 8437c28.
Thanks @pixelzoom. I've reverted the renaming commits done above to use the old image filenames. This is now ready for your review. |
Conversion looks good. I found a couple of things in area-model-common that were vestigial (GameScreenIcon, JugglerPortrayal), and deleted them in the above commit. Back to @Luisav1 in case there's anything else that is vestigial that I'm not aware of. Feel free to close if there's nothing else to do. |
Thanks for tidying up the vestigial items in area-model-common. Sorry for missing those files initially, I found no other vestigial items. Closing. |
For phetsims/joist#958 to use localizedImageProperty in Area Model Multiplication and Area Model Algebra.
The text was updated successfully, but these errors were encountered: