Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line in front of drag handle #172

Closed
KatieWoe opened this issue Dec 10, 2018 · 4 comments
Closed

Line in front of drag handle #172

KatieWoe opened this issue Dec 10, 2018 · 4 comments
Assignees
@amanda-phet
Labels
type:question

Comments

@KatieWoe
Copy link

For phetsims/qa#231.
When the drag handle is at the edge of the graph the outer lines seem to be in front of it, which seems odd to me. This is how it is in the published version.
graphdrag
@jonathanolson
Copy link
Contributor

I agree this looks nicer with a change to layering:

area-model-layering

@amanda-phet any objections to making the change to have it in front?

@jonathanolson jonathanolson removed their assignment Dec 10, 2018
@amanda-phet
Copy link
Contributor

Nope, that is a great suggestion! Thanks for finding that @KatieWoe .

jonathanolson added a commit that referenced this issue Dec 18, 2018
@jonathanolson
Move the proportional drag handle in front of the area and border, see …
81283b1 
…#172
jonathanolson added a commit that referenced this issue Dec 18, 2018
@jonathanolson
Move the proportional drag handle in front of the area and border, see …
1f66b13 
…#172
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Dec 18, 2018
@jonathanolson
updated dependencies.json for phetsims/area-model-common#172
5fe784c
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue Dec 18, 2018
@jonathanolson
updated dependencies.json for phetsims/area-model-common#172
61ce4df
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue Dec 18, 2018
@jonathanolson
updated dependencies.json for phetsims/area-model-common#172
a982fc2
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Dec 18, 2018
@jonathanolson
updated dependencies.json for phetsims/area-model-common#172
4b6ce26
@jonathanolson
Copy link
Contributor

Patched in master, and applied to the RCs. @amanda-phet can you verify that master (off phettest) looks good here?

@amanda-phet
Copy link
Contributor

Looks good on all 4 sims!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-phet amanda-phet

Labels
type:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @amanda-phet @KatieWoe