Skip to content

Commit

Permalink
Renaming load-runtime-strings.js => load-unbuilt-strings.js, and rena…
Browse files Browse the repository at this point in the history
…ming string module files, see phetsims/chipper#922
  • Loading branch information
jonathanolson committed Mar 31, 2020
1 parent 76babd7 commit cce51ce
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions area-builder_en.html
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@
};

// Kick off string loading immediately
loadURL( '../chipper/js/load-runtime-strings.js' );
loadURL( '../chipper/js/load-unbuilt-strings.js' );

// Queue all of the preloads to be loaded.
preloads.forEach( preload => loadURL( preload ) );

// Module loading in compilation-free (development) mode will be kicked off once strings are loaded.
// This is done in load-runtime-strings.js
// This is done in load-unbuilt-strings.js
window.phet.chipper.loadModules = () => loadURL( 'js/area-builder-main.js', 'module' );
</script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion js/area-builder-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import Sim from '../../joist/js/Sim.js';
import SimLauncher from '../../joist/js/SimLauncher.js';
import Tandem from '../../tandem/js/Tandem.js';
import areaBuilderStrings from './area-builder-strings.js';
import areaBuilderStrings from './areaBuilderStrings.js';
import AreaBuilderExploreScreen from './explore/AreaBuilderExploreScreen.js';
import AreaBuilderGameScreen from './game/AreaBuilderGameScreen.js';

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion js/common/AreaBuilderSharedConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import Bounds2 from '../../../dot/js/Bounds2.js';
import areaBuilderStrings from '../area-builder-strings.js';
import areaBuilderStrings from '../areaBuilderStrings.js';
import areaBuilder from '../areaBuilder.js';

const invalidValueString = areaBuilderStrings.invalidValue;
Expand Down
2 changes: 1 addition & 1 deletion js/explore/AreaBuilderExploreScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Screen from '../../../joist/js/Screen.js';
import inherit from '../../../phet-core/js/inherit.js';
import Image from '../../../scenery/js/nodes/Image.js';
import exploreIcon from '../../images/explore-icon_png.js';
import areaBuilderStrings from '../area-builder-strings.js';
import areaBuilderStrings from '../areaBuilderStrings.js';
import areaBuilder from '../areaBuilder.js';
import AreaBuilderSharedConstants from '../common/AreaBuilderSharedConstants.js';
import AreaBuilderIconFactory from '../common/view/AreaBuilderIconFactory.js';
Expand Down
2 changes: 1 addition & 1 deletion js/explore/view/AreaAndPerimeterDisplay.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import PhetFont from '../../../../scenery-phet/js/PhetFont.js';
import Node from '../../../../scenery/js/nodes/Node.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import AccordionBox from '../../../../sun/js/AccordionBox.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';

const areaString = areaBuilderStrings.area;
Expand Down
2 changes: 1 addition & 1 deletion js/game/AreaBuilderGameScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Screen from '../../../joist/js/Screen.js';
import inherit from '../../../phet-core/js/inherit.js';
import Image from '../../../scenery/js/nodes/Image.js';
import gameIcon from '../../images/game-icon_png.js';
import areaBuilderStrings from '../area-builder-strings.js';
import areaBuilderStrings from '../areaBuilderStrings.js';
import areaBuilder from '../areaBuilder.js';
import AreaBuilderSharedConstants from '../common/AreaBuilderSharedConstants.js';
import AreaBuilderIconFactory from '../common/view/AreaBuilderIconFactory.js';
Expand Down
4 changes: 2 additions & 2 deletions js/game/view/AreaBuilderGameView.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import Animation from '../../../../twixt/js/Animation.js';
import Easing from '../../../../twixt/js/Easing.js';
import GameAudioPlayer from '../../../../vegas/js/GameAudioPlayer.js';
import LevelCompletedNode from '../../../../vegas/js/LevelCompletedNode.js';
import vegasStrings from '../../../../vegas/js/vegas-strings.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import vegasStrings from '../../../../vegas/js/vegasStrings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';
import AreaBuilderSharedConstants from '../../common/AreaBuilderSharedConstants.js';
import AreaBuilderControlPanel from '../../common/view/AreaBuilderControlPanel.js';
Expand Down
4 changes: 2 additions & 2 deletions js/game/view/AreaBuilderScoreboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import Node from '../../../../scenery/js/nodes/Node.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import VBox from '../../../../scenery/js/nodes/VBox.js';
import GameTimer from '../../../../vegas/js/GameTimer.js';
import vegasStrings from '../../../../vegas/js/vegas-strings.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import vegasStrings from '../../../../vegas/js/vegasStrings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';

const labelScorePatternString = vegasStrings.label.scorePattern;
Expand Down
2 changes: 1 addition & 1 deletion js/game/view/GameInfoBanner.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import Rectangle from '../../../../scenery/js/nodes/Rectangle.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import Animation from '../../../../twixt/js/Animation.js';
import Easing from '../../../../twixt/js/Easing.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';
import ColorProportionsPrompt from './ColorProportionsPrompt.js';

Expand Down
2 changes: 1 addition & 1 deletion js/game/view/StartGameLevelNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import PhetFont from '../../../../scenery-phet/js/PhetFont.js';
import Node from '../../../../scenery/js/nodes/Node.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import LevelSelectionButton from '../../../../vegas/js/LevelSelectionButton.js';
import vegasStrings from '../../../../vegas/js/vegas-strings.js';
import vegasStrings from '../../../../vegas/js/vegasStrings.js';
import areaBuilder from '../../areaBuilder.js';
import AreaBuilderSharedConstants from '../../common/AreaBuilderSharedConstants.js';

Expand Down
2 changes: 1 addition & 1 deletion js/game/view/YouBuiltWindow.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import inherit from '../../../../phet-core/js/inherit.js';
import StringUtils from '../../../../phetcommon/js/util/StringUtils.js';
import PhetFont from '../../../../scenery-phet/js/PhetFont.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';
import ColorProportionsPrompt from './ColorProportionsPrompt.js';
import FeedbackWindow from './FeedbackWindow.js';
Expand Down
2 changes: 1 addition & 1 deletion js/game/view/YouEnteredWindow.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import inherit from '../../../../phet-core/js/inherit.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import areaBuilderStrings from '../../area-builder-strings.js';
import areaBuilderStrings from '../../areaBuilderStrings.js';
import areaBuilder from '../../areaBuilder.js';
import FeedbackWindow from './FeedbackWindow.js';

Expand Down

0 comments on commit cce51ce

Please sign in to comment.