Skip to content

Commit

Permalink
turn on todo-should-have-issue.js for all repos, phetsims/tasks#1128
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Sep 13, 2023
1 parent 7dd117d commit c506288
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
5 changes: 1 addition & 4 deletions area-builder_en.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,7 @@
]
},
"eslintConfig": {
"extends": "../chipper/eslint/sim_eslintrc.js",
"rules": {
"todo-should-have-issue": "off"
}
"extends": "../chipper/eslint/sim_eslintrc.js"
}
};
window.phet.chipper.stringRepos =
Expand Down
2 changes: 1 addition & 1 deletion js/common/model/ShapePlacementBoard.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ class ShapePlacementBoard {
return ( listener.shapePlacementBoard && listener.shapePlacementBoard === this );
}

// TODO: This is rather ugly. Work with SR to improve or find alternative, or to bake into Axon. Maybe a map.
// TODO: This is rather ugly. Work with SR to improve or find alternative, or to bake into Axon. Maybe a map. https://github.com/phetsims/tasks/issues/1129
// @private, remove all observers from a property that have been tagged by this shape placement board.
removeTaggedObservers( property ) {
const taggedObservers = [];
Expand Down
2 changes: 1 addition & 1 deletion js/common/view/PerimeterShapeNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class PerimeterShapeNode extends Node {
dimensionLabel.visible = true;
dimensionLabel.string = segmentLabelInfo.unitLength;
const labelPositionOffset = new Vector2( 0, 0 );
// TODO: At the time of this writing there is an issue with Shape.containsPoint() that can make
// TODO: At the time of this writing there is an issue with Shape.containsPoint() that can make https://github.com/phetsims/tasks/issues/1129
// containment testing unreliable if there is an edge on the same line as the containment test. As a
// workaround, the containment test offset is tweaked a little below. Once this issue is fixed, the
// label offset itself can be used for the test. See https://github.com/phetsims/kite/issues/3.
Expand Down
2 changes: 1 addition & 1 deletion js/game/view/StartGameLevelNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/**
* A node that pretty much fills the screen and that allows the user to select the game level that they wish to play.
*
* TODO: This was copied from Balancing Act, used for fast proto, should be replaced with generalized version.
* TODO: This was copied from Balancing Act, used for fast proto, should be replaced with generalized version. https://github.com/phetsims/tasks/issues/1129
*
* @author John Blanco
*/
Expand Down
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@
]
},
"eslintConfig": {
"extends": "../chipper/eslint/sim_eslintrc.js",
"rules": {
"todo-should-have-issue": "off"
}
"extends": "../chipper/eslint/sim_eslintrc.js"
}
}

0 comments on commit c506288

Please sign in to comment.