Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whole repo is linted like node #66

Closed
zepumph opened this issue Jan 17, 2019 · 1 comment
Closed

whole repo is linted like node #66

zepumph opened this issue Jan 17, 2019 · 1 comment
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 17, 2019

From phetsims/tasks#972, In aqua/package.json I made this repo extend the nodejs lint rules.

@jonathanolson I know that there is some server code and some browser code in this repo, but in order to successfully lint both separately, they need to be in different directories. I see two ways to proceed:

  1. Decide that just one lint configuration is worth our time, and have that in the package.json
  2. Separate out the browser stuff into its own dir, and add an eslintrc.js config there that makes it sim_es6_eslintrc which is basically our browser es6 rules.

What do you think @jonathanolson?

@zepumph
Copy link
Member Author

zepumph commented Jun 9, 2022

I noticed that browser code is really just in a couple of directories, so I added this file to them:

// Copyright 2022, University of Colorado Boulder
// @author Michael Kauzmann


module.exports = {
  extends: '../../../chipper/eslint/sim_eslintrc.js',

  rules: {
    'bad-sim-text': 'off'
  },
  globals: {
    aqua: 'readonly'
  }
};

Lint is passing, and life is good. Closing

@zepumph zepumph closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants