Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WebGL on sparky #174

Open
zepumph opened this issue Apr 28, 2023 · 3 comments
Open

Support WebGL on sparky #174

zepumph opened this issue Apr 28, 2023 · 3 comments
Labels
priority:5-deferred

Comments

@zepumph
Copy link
Member

zepumph commented Apr 28, 2023

From https://github.com/phetsims/special-ops/issues/234. Remember that one option here is turning off the gpu of puppeteer instances if the gpu can't handle it.
jonathanolson added a commit that referenced this issue Apr 28, 2023
@jonathanolson
Turn off webgl on puppeteer loading, see #174
d81d13d
jonathanolson added a commit to phetsims/perennial that referenced this issue Apr 28, 2023
@jonathanolson
Turn off webgl on puppeteer loading, see phetsims/aqua#174
f7439ca
jonathanolson added a commit to phetsims/chipper that referenced this issue Apr 28, 2023
@jonathanolson
Turn off webgl on puppeteer loading, see phetsims/aqua#174
e1552ae
@zepumph
Copy link
Member Author

zepumph commented Apr 28, 2023

At this time we decided not to use Webgl, and so we turned it off for all puppeteer launches that could run into this (running on servers without a gpu). Both @jonathanolson and I were a bit surprised to hear that we didn't get a GPU with sparky, but I believe they were pretty expensive. Anywho, closing this for now.

@zepumph zepumph closed this as completed Apr 28, 2023
@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2023

We ran into tension behind not having a graphics card for sparky over in https://github.com/phetsims/phet-io-wrappers/issues/551#issuecomment-1765403285. It would be nice to potentially revisit getting a graphics card on sparky because of the alpenglow work.

@zepumph zepumph reopened this Oct 17, 2023
@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2023

After some discussion with @jonathanolson @samreid, the best path forward here is not to get a graphics card on sparky, but instead to use other devices to tap into the testing logic, like a macbook with a graphics card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @zepumph