Upgrade to ESLint 9 and flat config, see phetsims/chipper#1474

doc/generate-bibliography.js

@@ -5,9 +5,7 @@
 // Generates the bibliography for the Alpenglow documentation
 // Run with `node js/generate-bibliography.js`
 
-/* eslint-env node */
-
-const Cite = require( 'citation-js' ); // eslint-disable-line require-statement-match
+const Cite = require( 'citation-js' ); // eslint-disable-line phet/require-statement-match
 const fs = require( 'fs' );
 
 ( async () => {

doc/index.js

@@ -18,11 +18,11 @@ if ( window.usePhetLib ) {
 }
 // Otherwise, load from our transpilation (assuming for development mode)
 else {
-  alpenglow = ( await import( '../../chipper/dist/js/alpenglow/js/main.js' ) ).default; // eslint-disable-line bad-sim-text
-  ArrowNode = ( await import( '../../chipper/dist/js/scenery-phet/js/ArrowNode.js' ) ).default; // eslint-disable-line bad-sim-text
-  scenery = ( await import( '../../chipper/dist/js/scenery/js/main.js' ) ).default; // eslint-disable-line bad-sim-text
-  kite = ( await import( '../../chipper/dist/js/kite/js/main.js' ) ).default; // eslint-disable-line bad-sim-text
-  dot = ( await import( '../../chipper/dist/js/dot/js/main.js' ) ).default; // eslint-disable-line bad-sim-text
+  alpenglow = ( await import( '../../chipper/dist/js/alpenglow/js/main.js' ) ).default; // eslint-disable-line phet/bad-sim-text
+  ArrowNode = ( await import( '../../chipper/dist/js/scenery-phet/js/ArrowNode.js' ) ).default; // eslint-disable-line phet/bad-sim-text
+  scenery = ( await import( '../../chipper/dist/js/scenery/js/main.js' ) ).default; // eslint-disable-line phet/bad-sim-text
+  kite = ( await import( '../../chipper/dist/js/kite/js/main.js' ) ).default; // eslint-disable-line phet/bad-sim-text
+  dot = ( await import( '../../chipper/dist/js/dot/js/main.js' ) ).default; // eslint-disable-line phet/bad-sim-text
 }
 
 const Node = scenery.Node;
@@ -246,7 +246,7 @@ window.createRenderProgramSandbox = ( id, func, width, height, providedOptions )
     errorsContainerElement.style.display = 'none';
 
     try {
-      // eslint-disable-next-line bad-sim-text
+      // eslint-disable-next-line phet/bad-sim-text
       const code = `${Math.random()};
       let value = (${options.jsBefore}
         const dot = phet.dot;
@@ -425,7 +425,7 @@ setTimeout( () => {
     }
   };
   window.addDiagram = addDiagram;
-  // eslint-disable-next-line bad-sim-text
+  // eslint-disable-next-line phet/bad-sim-text
   window.pendingDiagrams.forEach( diagram => setTimeout( () => addDiagram( diagram.id, diagram.callback ), 0 ) );
 }, 0 );
 
@@ -2383,7 +2383,7 @@ window.createSceneryDiagram = ( scene, width, height, needsWhiteBackground = fal
           renderProgram = new RenderNormalDebug( normalProgram );
         }
         else if ( shadeType === 'random' ) {
-          // eslint-disable-next-line bad-sim-text
+          // eslint-disable-next-line phet/bad-sim-text
           renderProgram = new RenderColor( v4( Math.random(), Math.random(), Math.random(), 1 ) );
         }
 

doc/load-mermaid.js

@@ -2,5 +2,5 @@
 
 // @author Jonathan Olson <[email protected]>
 
-import mermaid from '../../sherpa/mermaid/mermaid.esm.min.mjs'; // eslint-disable-line default-import-match-filename
+import mermaid from '../../sherpa/mermaid/mermaid.esm.min.mjs'; // eslint-disable-line phet/default-import-match-filename
 mermaid.initialize( { startOnLoad: true } );

js/parallel/ParallelExecutor.ts

@@ -25,7 +25,7 @@ import { alpenglow, BaseWorkgroupValues, ParallelContext, ParallelKernel, Parall
 import Random from '../../../dot/js/Random.js';
 import Vector3 from '../../../dot/js/Vector3.js';
 
-// eslint-disable-next-line bad-sim-text
+// eslint-disable-next-line phet/bad-sim-text
 const random = new Random();
 
 const LOG = false;

js/parallel/ParallelTests.ts

@@ -11,7 +11,7 @@
 import { ParallelContext, ParallelExecutor, ParallelKernel, ParallelStorageArray, ParallelWorkgroupArray } from '../imports.js';
 import Random from '../../../dot/js/Random.js';
 
-// eslint-disable-next-line bad-sim-text
+// eslint-disable-next-line phet/bad-sim-text
 const random = new Random();
 
 QUnit.module( 'Parallel' );

js/raster/Rasterize.ts

@@ -1060,7 +1060,7 @@ export default class Rasterize {
         }
         else if ( options.edgeIntersectionSortMethod === 'random' ) {
           // NOTE: This is NOT designed for performance (it's for testing)
-          // eslint-disable-next-line bad-sim-text
+          // eslint-disable-next-line phet/bad-sim-text
           const shuffled = _.shuffle( integerEdges );
           integerEdges.length = 0;
           integerEdges.push( ...shuffled );

js/render-program/RenderProgram.ts

@@ -6,7 +6,7 @@
  * @author Jonathan Olson <[email protected]>
  */
 
-// eslint-disable-next-line single-line-import
+// eslint-disable-next-line phet/single-line-import
 import {
   alpenglow,
   ClippableFace,

js/webgpu/FaceRasterizer.ts

@@ -252,12 +252,12 @@ export default class FaceRasterizer {
     const renderableFaces = Rasterize.partitionRenderableFaces( program, bounds, {
       tileSize: 1024 * 1024, // don't do tiles by default
 
-      // eslint-disable-next-line no-object-spread-on-non-literals
+      // eslint-disable-next-line phet/no-object-spread-on-non-literals
       ...rasterizeOptions
     } );
 
     return this.run( {
-      // eslint-disable-next-line no-object-spread-on-non-literals
+      // eslint-disable-next-line phet/no-object-spread-on-non-literals
       ...runOptions,
       renderableFaces: renderableFaces
     } );

js/webgpu/GPUProfiling.ts

@@ -25,7 +25,7 @@
 import { alpenglow, BufferArraySlot, BufferLogger, DeviceContext, getArrayType, Procedure, RadixSortModule, Routine, TimestampLogger, TimestampLoggerResult, U32Order, u32S } from '../imports.js';
 import Random from '../../../dot/js/Random.js';
 
-// eslint-disable-next-line bad-sim-text
+// eslint-disable-next-line phet/bad-sim-text
 const random = new Random();
 
 class GPUProfiler {

js/webgpu/PerformanceTesting.ts

@@ -19,7 +19,7 @@ export default class PerformanceTesting {
     const inputSize = 4000;
     // const inputSize = workgroupSize * workgroupSize * ( 6 ) - 27 * 301;
     // const inputSize = workgroupSize * workgroupSize * ( workgroupSize - 3 ) - 27 * 301;
-    // eslint-disable-next-line bad-sim-text
+    // eslint-disable-next-line phet/bad-sim-text
     const uintNumbers = new Uint32Array( _.range( 0, inputSize ).map( () => Math.floor( Math.random() * 1000000 ) ) );
 
     const device = ( await DeviceContext.getDevice() )!;

js/webgpu/WebGPURecorder.ts

@@ -531,7 +531,7 @@ class WebGPUCommandDeviceCreateBuffer extends WebGPUCommand {
     return `${this.getDeclaration( nameMap )}${getName( nameMap, this.device )}.createBuffer( ${WebGPURecorder.rawValue( level, this.descriptor, nameMap, {
       usage: ( value: IntentionalAny ) => {
         const numberValue = value as number;
-        // eslint-disable-next-line no-simple-type-checking-assertions
+        // eslint-disable-next-line phet/no-simple-type-checking-assertions
         assert && assert( typeof value === 'number' );
         
         return WebGPURecorder.bitfieldToString( numberValue, new Map<number, string>( [

js/webgpu/compute/ByteEncoder.ts

@@ -404,7 +404,7 @@ export default class ByteEncoder {
     let iLow = Math.max( 0, k - n );
     let jLow = Math.max( 0, k - m );
     let delta;
-    // eslint-disable-next-line no-constant-condition
+     // TODO: Where did no-constant-condition go? See https://github.com/phetsims/chipper/issues/1451
     while ( true ) {
       if ( i > 0 && j < n && compare( i - 1, j ) > 0 ) {
         delta = ( i - iLow + 1 ) >> 1;

js/webgpu/compute/ConcreteType.ts

@@ -12,7 +12,7 @@ import Random from '../../../../dot/js/Random.js';
 import Vector3 from '../../../../dot/js/Vector3.js';
 import Vector4 from '../../../../dot/js/Vector4.js';
 
-// eslint-disable-next-line bad-sim-text
+// eslint-disable-next-line phet/bad-sim-text
 const random = new Random();
 
 export type WGSLBinaryStatements = ( value: WGSLVariableName, a: WGSLExpression, b: WGSLExpression ) => WGSLStatements;
@@ -303,7 +303,7 @@ alpenglow.register( 'getVariableLengthArrayType', getVariableLengthArrayType );
 
 export const getCastedType = <T>( type: ConcreteType<T>, valueType: WGSLType ): ConcreteType<T> => {
   return {
-    // eslint-disable-next-line no-object-spread-on-non-literals
+    // eslint-disable-next-line phet/no-object-spread-on-non-literals
     ...type,
     valueType: valueType
   };

js/webgpu/compute/IndirectModule.ts

@@ -16,7 +16,7 @@ export type IndirectModuleOptions<T> = {
 } & PipelineBlueprintOptions;
 
 export const INDIRECT_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...PIPELINE_BLUEPRINT_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/HistogramModule.ts

@@ -16,9 +16,9 @@ export type HistogramModuleOptions<T> = {
 } & mainHistogramWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const HISTOGRAM_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_HISTOGRAM_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainRadixHistogramModule.ts

@@ -16,9 +16,9 @@ export type MainRadixHistogramModuleOptions<T> = {
 } & mainRadixHistogramWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_RADIX_HISTOGRAM_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_RADIX_HISTOGRAM_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainRadixScatterModule.ts

@@ -16,9 +16,9 @@ export type MainRadixScatterModuleOptions<T> = {
 } & mainRadixScatterWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_RADIX_SCATTER_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_RADIX_SCATTER_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainReduceAtomicModule.ts

@@ -17,9 +17,9 @@ export type MainReduceAtomicModuleOptions<T> = {
 } & mainReduceAtomicWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_REDUCE_ATOMIC_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_REDUCE_ATOMIC_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainReduceModule.ts

@@ -16,9 +16,9 @@ export type MainReduceModuleOptions<T> = {
 } & mainReduceWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_REDUCE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_REDUCE_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainReduceNonCommutativeModule.ts

@@ -16,9 +16,9 @@ export type MainReduceNonCommutativeModuleOptions<T> = {
 } & mainReduceNonCommutativeWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_REDUCE_NON_COMMUTATIVE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_REDUCE_NON_COMMUTATIVE_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MainScanModule.ts

@@ -20,9 +20,9 @@ export type MainScanModuleOptions<T> = {
 } & mainScanWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MAIN_SCAN_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_SCAN_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MergeModule.ts

@@ -17,9 +17,9 @@ export type MergeModuleOptions<T> = {
 } & mainMergeWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MERGE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_MERGE_DEFAULTS
 } as const;
 

js/webgpu/modules/gpu/MergeSimpleModule.ts

@@ -17,9 +17,9 @@ export type MergeSimpleModuleOptions<T> = {
 } & mainMergeSimpleWGSLOptions<T> & PipelineBlueprintOptions;
 
 export const MERGE_SIMPLE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_MERGE_SIMPLE_DEFAULTS
 } as const;
 

js/webgpu/modules/rasterize-two-pass/MainTwoPassCoarseModule.ts

@@ -23,9 +23,9 @@ export type MainTwoPassCoarseModuleOptions = {
 } & mainTwoPassCoarseWGSLOptions & PipelineBlueprintOptions;
 
 export const MAIN_TWO_PASS_COARSE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_TWO_PASS_COARSE_DEFAULTS
 } as const;
 

js/webgpu/modules/rasterize-two-pass/MainTwoPassFineModule.ts

@@ -20,9 +20,9 @@ export type MainTwoPassFineModuleOptions = {
 } & mainTwoPassFineWGSLOptions & PipelineBlueprintOptions;
 
 export const MAIN_TWO_PASS_FINE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_TWO_PASS_FINE_DEFAULTS
 } as const;
 

js/webgpu/modules/rasterize-two-pass/MainTwoPassInitializeAddressesModule.ts

@@ -15,9 +15,9 @@ export type MainTwoPassInitializeAddressesModuleOptions = {
 } & mainTwoPassInitializeAddressesWGSLOptions & PipelineBlueprintOptions;
 
 export const MAIN_TWO_PASS_INITIALIZE_ADDRESSES_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_TWO_PASS_INITIALIZE_ADDRESSES_DEFAULTS
 } as const;
 

js/webgpu/modules/rasterize-two-pass/MainTwoPassTileModule.ts

@@ -23,9 +23,9 @@ export type MainTwoPassTileModuleOptions = {
 } & mainTwoPassTileWGSLOptions & PipelineBlueprintOptions;
 
 export const MAIN_TWO_PASS_TILE_MODULE_DEFAULTS = {
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...DIRECT_MODULE_DEFAULTS,
-  // eslint-disable-next-line no-object-spread-on-non-literals
+  // eslint-disable-next-line phet/no-object-spread-on-non-literals
   ...MAIN_TWO_PASS_TILE_DEFAULTS
 } as const;
 

js/webgpu/modules/rasterize-two-pass/TiledTwoPassModule.ts

@@ -74,7 +74,7 @@ export default class TiledTwoPassModule extends CompositeModule<TiledTwoPassRunS
       name: `${providedOptions.name} atomic initialize_addresses`,
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
-      ...options.mainTwoPassAtomicInitializeAddressesModuleOptions, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.mainTwoPassAtomicInitializeAddressesModuleOptions, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       addresses: addressesPlainSlot
     } );
@@ -84,7 +84,7 @@ export default class TiledTwoPassModule extends CompositeModule<TiledTwoPassRunS
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
       numInitialRenderableFaces: options.numInitialRenderableFaces,
-      ...options.mainTwoPassTileModuleOptions, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.mainTwoPassTileModuleOptions, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       // input
       config: providedOptions.config,
@@ -101,7 +101,7 @@ export default class TiledTwoPassModule extends CompositeModule<TiledTwoPassRunS
       name: `${providedOptions.name} two pass`,
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
-      ...options.twoPassModuleOptions, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.twoPassModuleOptions, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       config: providedOptions.config,
       coarseRenderableFaces: coarseRenderableFacesSlot,

js/webgpu/modules/rasterize-two-pass/TwoPassModule.ts

@@ -82,7 +82,7 @@ export default class TwoPassModule extends CompositeModule<TwoPassRunSize> {
       name: `${providedOptions.name} initialize_addresses`,
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
-      ...options.mainTwoPassInitializeAddressesModule, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.mainTwoPassInitializeAddressesModule, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       addresses: addressesPlainSlot
     } );
@@ -91,7 +91,7 @@ export default class TwoPassModule extends CompositeModule<TwoPassRunSize> {
       name: `${providedOptions.name} coarse`,
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
-      ...options.mainTwoPassCoarseModuleOptions, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.mainTwoPassCoarseModuleOptions, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       // input
       config: providedOptions.config,
@@ -110,7 +110,7 @@ export default class TwoPassModule extends CompositeModule<TwoPassRunSize> {
       name: `${providedOptions.name} fine`,
 
       log: providedOptions.log, // TODO: how can we avoid needing this forward?
-      ...options.mainTwoPassFineModuleOptions, // eslint-disable-line no-object-spread-on-non-literals
+      ...options.mainTwoPassFineModuleOptions, // eslint-disable-line phet/no-object-spread-on-non-literals
 
       config: providedOptions.config,
       addresses: addressesPlainSlot,