Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Dialog needs RSC Acknowledgement #108

Closed
kathy-phet opened this issue Apr 16, 2014 · 6 comments
Closed

About Dialog needs RSC Acknowledgement #108

kathy-phet opened this issue Apr 16, 2014 · 6 comments
Labels

Comments

@kathy-phet
Copy link

Need to add RSC acknowledgement - as in pH Scale. Please add it as the first in the "Thanks." section. Before MLL.

@pixelzoom pixelzoom added the bug label Apr 16, 2014
@pixelzoom
Copy link
Contributor

Will do. Same acknowledgment as pH Scale?

Conversion of this simulation to HTML5 was funded in part by the Royal Society of Chemistry.

@pixelzoom
Copy link
Contributor

Screenshot attached for your approval. The ‘Thanks’ section is manually broken into multiple lines using scenery-phet.MultiLineText, which does not support blank lines. So I added bullets in front of each acknowledgement to delineate them. Look OK?

screenshot_249

@ariel-phet
Copy link

Looks OK....If it is not a huge bother I would align "simulation" with the "T" for thanks so it looks more like a clean bullet point. But again, not a huge deal, more a nit pick.

@pixelzoom
Copy link
Contributor

Not possible to do the alignment you've proposed. I agree it would look much nicer. But MultiLineText is dumb and the only thing that it can do is insert line breaks. scenery.HTMLText could provide nice formatting, but we're avoiding it because of memory issues.

@pixelzoom
Copy link
Contributor

Two issues should be considered when addressing phetsims/joist#71 (About dialog needs lipstick):

  1. layout and indentation of credits
  2. multiple entries for 'Thank You' section

@pixelzoom
Copy link
Contributor

@kathy-phet said via email: Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants