Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSSReaderDeclarationList missing methods to pass in CReaderSettings as argument #78

Closed
shagkur opened this issue Jan 13, 2022 · 1 comment
Closed

CSSReaderDeclarationList missing methods to pass in CReaderSettings as argument #78

shagkur opened this issue Jan 13, 2022 · 1 comment
Assignees
@phax
Labels
enhancement

Comments

@shagkur
Copy link
Contributor

shagkur commented Jan 13, 2022 •
edited
Loading

For API completeness it'd be nice to have the other reader methods support the CSSReaderSettings as additional argument, like CSSReaderDeclarationList.readFromReader(reader,readerSettings).
Similar to CSSReader implementation.
@phax phax self-assigned this Jan 13, 2022
phax added a commit that referenced this issue Jan 13, 2022
@phax
Extended API; #78
43f55b6
@phax
Copy link
Owner

phax commented Jan 13, 2022

Thanks for pointing that out. Part of 6.4.3

@phax phax closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @shagkur