Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:host and ::slotted parsing sort of wrong #77

Closed
shagkur opened this issue Jan 12, 2022 · 6 comments
Closed

:host and ::slotted parsing sort of wrong #77

shagkur opened this issue Jan 12, 2022 · 6 comments
Assignees
Labels

Comments

@shagkur
Copy link
Contributor

shagkur commented Jan 12, 2022

This is a follow up issue to the recently merged PR.
I figured that

(<S>)*
( simpleSelectorSequence() )? 

is not correct.
It should rather be

(<S>)*
( simpleSelectorSequence() (<S>)* )* 

see: https://developer.mozilla.org/en-US/docs/Web/CSS/::slotted

Although i'm not quite sure about the trailing ()* here. WDYT?

I'll file a PR soonish

@phax phax self-assigned this Jan 12, 2022
@phax phax added the bug label Jan 12, 2022
@phax
Copy link
Owner

phax commented Jan 12, 2022

No need to PR - thx

@shagkur
Copy link
Contributor Author

shagkur commented Jan 12, 2022

Sorry if i messed this up with my previous PR

@phax
Copy link
Owner

phax commented Jan 12, 2022

No worries - all good

phax added a commit that referenced this issue Jan 12, 2022
@phax
Copy link
Owner

phax commented Jan 12, 2022

I needed to change the members types of the selectors in CSSSelectorMemberSlotted and CSSSelectorMemberHost - but that should be no big deal

@shagkur
Copy link
Contributor Author

shagkur commented Jan 12, 2022

Thanks alot for your quick response on this :) Very appreciated :)

@phax
Copy link
Owner

phax commented Jan 12, 2022

Fixed in 6.4.2

@phax phax closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants