Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port unary operation reduction to new normalization interface #714

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

phate
Copy link
Owner

@phate phate commented Jan 3, 2025

No description provided.

@phate phate requested a review from haved January 3, 2025 22:08
@phate phate enabled auto-merge (squash) January 3, 2025 22:08
@phate phate requested a review from caleridas January 3, 2025 22:11
haved
haved previously approved these changes Jan 4, 2025
Copy link
Collaborator

@haved haved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, just one small question about the vector constructor used

jlm/rvsdg/unary.cpp Outdated Show resolved Hide resolved
@phate phate force-pushed the Normalization-UnaryOperation branch from 7b7670a to e9cbb82 Compare January 4, 2025 12:27
@phate phate merged commit 44cfb7a into master Jan 4, 2025
12 checks passed
@phate phate deleted the Normalization-UnaryOperation branch January 4, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants