-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function pointer conversion #705
Conversation
The operator names are quite verbose -- happy to abbreviate them if desired. |
11a5f51
to
9df334b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether I missed something, but I do not think you need to cast it to a simple node first before you cast it to a concrete node
512b6ad
to
e7dc862
Compare
e7dc862
to
ece942f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did not think about it the first time, but you might want to inherit it from unary_op class instead of from SimpleOperation.
ece942f
to
8117aaa
Compare
Okay changed it, it forces in the unary reduction methods -- which is the thing you are reworking in another commit, though, so let's see. |
8117aaa
to
db52afd
Compare
db52afd
to
9c64ffa
Compare
Add function / pointer conversion llvm operators. Accept these operators as top-level nodes in the various transformation passes, and handle them in instruction conversion. There are presently no "users" of these operators or anything that puts them into the graph -- so this is preparatory for making function and pointer distinction in a later commit.
9c64ffa
to
d970b7a
Compare
Add function / pointer conversion llvm operators. Accept these operators as top-level nodes in the various transformation passes, and handle them in instruction conversion.
There are presently no "users" of these operators or anything that puts them into the graph -- so this is preparatory for making function and pointer distinction in a later commit.