Add bugprone-move-forwarding-reference check to clang-tidy

phate · Dec 21, 2024 · 91e6816 · 91e6816
1 parent 4821290
commit 91e6816
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,10 +1,12 @@
 ---
 Checks: '-*,
+  bugprone-move-forwarding-reference,
   modernize-deprecated-headers,
   modernize-redundant-void-arg,
   '
 
 WarningsAsErrors: '
+  bugprone-move-forwarding-reference,
   modernize-deprecated-headers,
   modernize-redundant-void-arg,
   '
diff --git a/jlm/rvsdg/reduction-helpers.hpp b/jlm/rvsdg/reduction-helpers.hpp
@@ -52,7 +52,7 @@ pairwise_reduce(Container && args, const Reductor & reductor)
 {
   if (args.empty())
   {
-    return std::move(args);
+    return std::forward(args);
   }
 
   auto left = args.begin();
@@ -75,7 +75,7 @@ pairwise_reduce(Container && args, const Reductor & reductor)
   }
   args.erase(std::next(left), args.end());
 
-  return std::move(args);
+  return std::forward(args);
 }
 
 /* Test whether any pair of elements of "args" can be reduced according
@@ -137,7 +137,7 @@ commutative_pairwise_reduce(Container && args, const Reductor & reductor)
     ++left;
   }
 
-  return std::move(args);
+  return std::forward(args);
 }
 
 /* Test whether "flatten_tester" applies to any element of "args". */