Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink for src/config directory #323

Closed
wants to merge 1 commit into from

Conversation

mike-potter
Copy link
Member

Added steps in scaffold.js to add the symlink from drupal docroot/config to src/config.

@mike-potter mike-potter requested a review from grayside August 16, 2017 16:56
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Basic test coverage is needed. This will require creating examples/src/config/.gitkeep
  2. As written, this seems like it will throw warnings if not errors for any project that upgrades to a version of GDT with this but does not have a src/config directory. While we would like D8 projects to use this, many will not, and I doubt we'll ever see a D7 project use it.
  3. This needs docs/

@grayside
Copy link
Contributor

We do not need to do Drupal core version detection, we should instead make the presence of src/config optional.

@scottalan
Copy link
Member

Brought this up in a meeting with @grayside. Wanted to link to this issue here: https://www.drupal.org/node/2899534

@scottalan
Copy link
Member

Basic test coverage is needed. This will require creating examples/src/config/.gitkeep

@grayside or @mike-potter In Atmosphere we are using config_split. We opted to create our directory structure like this, src/config/default, where default holds our main site configuration. We then have configuration that only exists in specific environments in other directories. Do we think it makes sense to create src/config/default/.gitkeep to make it easier for projects that will need to use config sync? I ask this purely from an organizational standpoint.

@grayside
Copy link
Contributor

There are two basic approaches we can take as far as symlinks: we can link to src/config from build/html/config, or we can link to src/config/* from build/html/config/*. For the latter, I mean the approach taken with symlinking profiles as opposed to the approach of symlinking modules (which uses build/html/modules/custom --> ../../../../src/modules.

I do not think gdt needs to present support for Config Split, but if having a config/default directory seems reasonable in the absence of config split I don't object.

@grayside grayside mentioned this pull request Oct 24, 2017
@grayside
Copy link
Contributor

Superceded by #330

@grayside grayside closed this Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants