Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/988 #989

Merged
merged 2 commits into from
Sep 5, 2018
Merged

issue/988 #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf03dff
Making the load of packages in a single operation.
tesonep Sep 3, 2018
df9ce8b
Fixing the description
tesonep Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions ...erg-Memory.package/IceRingWorkingCopy.class/instance/impactPackageChanges.currentNode..st
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions Iceberg-Memory.package/IceRingWorkingCopy.class/instance/loadChangesInWorkingCopy..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
private-changes
loadChangesInWorkingCopy: aTree

| visitor |
visitor := IceRingWorkingCopyChangerVisitor on: self.

self ignoreNotificationsDuring: [
aTree accept: visitor.
]
4 changes: 4 additions & 0 deletions Iceberg-Memory.package/IceRingWorkingCopyChangerVisitor.class/instance/environment.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
environment

^ self workingCopy environment
4 changes: 4 additions & 0 deletions Iceberg-Memory.package/IceRingWorkingCopyChangerVisitor.class/instance/packages.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
packages

^ self workingCopy packages
15 changes: 12 additions & 3 deletions Iceberg-Memory.package/IceRingWorkingCopyChangerVisitor.class/instance/visitPackage..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
visiting
visitPackage: anIcePackageDefinition

workingCopy
impactPackageChanges: anIcePackageDefinition
currentNode: currentNode
| visitor |

anIcePackageDefinition categories do: [ :categoryName |
self workingCopy packages
detect: [ :package | categoryName beginsWith: package name ]
ifFound: [ :package |
(self environment ensurePackageNamed: package name)
addClassTag: categoryName ]
ifNone: [ self environment ensurePackageNamed: categoryName ] ].

visitor := IceRingWorkingCopyChangerVisitor on: self workingCopy.
currentNode childrenDo: [ :each | each accept: visitor ]
4 changes: 4 additions & 0 deletions Iceberg-Memory.package/IceRingWorkingCopyChangerVisitor.class/instance/workingCopy.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
workingCopy

^ workingCopy
2 changes: 1 addition & 1 deletion Iceberg-TipUI.package/IceCheckoutAllPackages.extension/class/description.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
*Iceberg-TipUI
description
^ 'Checkout ALL packages in the repository, in alphabetical order'
^ 'Checkout ALL packages in the repository'
2 changes: 1 addition & 1 deletion Iceberg-TipUI.package/IceCheckoutAlreadyLoadedPackages.extension/class/description.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
*Iceberg-TipUI
description
^ 'Checkout packages ALREADY LOADED in the image, in alphabetical order'
^ 'Checkout packages ALREADY LOADED in the image'
12 changes: 0 additions & 12 deletions Iceberg.package/IceWorkingCopy.class/instance/impactPackageChanges.currentNode..st
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions Iceberg.package/IceWorkingCopy.class/instance/loadChangesInWorkingCopy..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
private-changes
loadChangesInWorkingCopy: aTree

| visitor |
visitor := IceWorkingCopyPatcherVisitor on: self repository.
aTree accept: visitor.

self ignoreNotificationsDuring: [
aTree accept: (IceWorkingCopyPatcherVisitor on: self repository)
]
visitor load.
]
4 changes: 4 additions & 0 deletions Iceberg.package/IceWorkingCopyPatcherVisitor.class/instance/initialize.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
initialization
initialize
super initialize.
loader := MCPackageLoader new
3 changes: 3 additions & 0 deletions Iceberg.package/IceWorkingCopyPatcherVisitor.class/instance/load.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
loading
load
loader load
11 changes: 7 additions & 4 deletions Iceberg.package/IceWorkingCopyPatcherVisitor.class/instance/visitPackage..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
visiting
visitPackage: anIcePackageDefinition

self repository workingCopy
impactPackageChanges: anIcePackageDefinition
currentNode: currentNode

(self repository packageNamed: anIcePackageDefinition name) isLoaded
ifFalse: [ ^ self ].

currentNode accept: (IceMCSnapshotPatchVisitor new
patcher: loader;
yourself).
3 changes: 2 additions & 1 deletion Iceberg.package/IceWorkingCopyPatcherVisitor.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"pools" : [ ],
"classvars" : [ ],
"instvars" : [
"repository"
"repository",
"loader"
],
"name" : "IceWorkingCopyPatcherVisitor",
"type" : "normal"
Expand Down