Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess the subdirectory while importing a local repository. #422

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Guess the subdirectory while importing a local repository. #422

merged 1 commit into from
Jul 25, 2017

Conversation

jecisc
Copy link
Contributor

@jecisc jecisc commented Jul 23, 2017

See: #421

@estebanlm
Copy link
Collaborator

I don't like the "chooseHook" name, is not coherent with our method names.
instead, I would use "onChoose" (and chooseBlock as instance variable).

@jecisc jecisc force-pushed the cf_guessLocalRepositorySubDirectory branch from 1e50b3f to 901fb7f Compare July 24, 2017 16:41
@jecisc
Copy link
Contributor Author

jecisc commented Jul 24, 2017

@estebanlm Done.

@estebanlm
Copy link
Collaborator

ok, just another remark: the common convention name for block closure parameters is "aBlock", not "aBlockClosure" :)
I will accept it with it since is not so bad, I'm telling you for the future :)

@estebanlm estebanlm merged commit e85ea8e into pharo-vcs:dev-0.5 Jul 25, 2017
@jecisc jecisc deleted the cf_guessLocalRepositorySubDirectory branch April 1, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jecisc @estebanlm