Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alerts to Iceberg's IceTipNewRepositoryPanel to Inform User of Incomplete Information #1834

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

acyed
Copy link
Contributor

@acyed acyed commented Aug 1, 2024

Fixes #16870

I have enhanced the validate methods by adding alerts to inform users about the necessary actions to continue. To allow the dialog to remain open, I had to modify the caller of validate.

This replaces the behavior of opening a debugging window on the failure of the assert calls.

Issue:
pharo-project/pharo#16870

I have enhanced the validate methods by adding alerts to inform users about the necessary actions to continue. To allow the dialog to remain open, I had to modify the caller of validate.
@Ducasse
Copy link
Collaborator

Ducasse commented Aug 1, 2024

Thanks a lot!
You can really improve Pharo. We are so concentrated so time consuming tasks that we forget the simple changes that can improve the user experience. This is why we started to introduce papercut tags.

@Ducasse
Copy link
Collaborator

Ducasse commented Aug 1, 2024

The broken tests seem unrelated

ReleaseTest
 ✗ #testUndeclared (149ms)
TestFailure: Found undeclared Variables: 
StSystemReporter in: SmalltalkCIPharo9>>#imageInfo
Gofer in: SCIGoferLoadSpec>>#basicLoadProjectOn:
ReleaseTest(TestAsserter)>>assert:description:resumable:
ReleaseTest(TestAsserter)>>assert:description:
ReleaseTest>>testUndeclared ...assert: remaining isEmpty description: description
ReleaseTest(TestCase)>>performTest
 ✗ #testNoEquivalentSuperclassMethods (1344ms)
TestFailure: Assertion failed
ReleaseTest(TestAsserter)>>assert:description:resumable:
ReleaseTest(TestAsserter)>>assert:description:
ReleaseTest(Object)>>assert:
ReleaseTest>>testNoEquivalentSuperclassMethods ...assert: methods size <= 326
ReleaseTest(TestCase)>>performTest

@Ducasse Ducasse requested review from jecisc and estebanlm August 1, 2024 08:00
@Ducasse
Copy link
Collaborator

Ducasse commented Aug 1, 2024

@jecisc @estebanlm can you have a look when you have time?
This looks ok for me.

@Ducasse Ducasse merged commit 7572143 into pharo-vcs:Pharo13 Aug 3, 2024
2 of 4 checks passed
@Rinzwind
Copy link
Contributor

This pull request seems to have introduced a bug, a NonBooleanReceiver is signaled when cloning a repository:

@Ducasse
Copy link
Collaborator

Ducasse commented Aug 10, 2024

THanks Kris so I will revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants