Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1775 ice tip tag model does not understand branch name when browsing tags #1776

Merged
merged 2 commits into from
Jan 18, 2024
Merged

1775 ice tip tag model does not understand branch name when browsing tags #1776

merged 2 commits into from
Jan 18, 2024

Conversation

astares
Copy link
Contributor

@astares astares commented Dec 5, 2023 •
edited
Loading

Fix #1776

@astares astares requested a review from tesonep December 5, 2023 22:58
@astares astares changed the title 1775 ice tip tag modeldoes not understand branch name when browsing tags 1775 ice tip tag model does not understand branch name when browsing tags Dec 5, 2023
@astares
Copy link
Contributor Author

astares commented Dec 5, 2023 •
edited
Loading

Two platforms green, one test fails on Windows #testFetchUpdatesTrackedRemoteBranch
(but it is also failing for other PRs like #1778) so it looks like a CI issue

image

and when I run this test manually with latest Pharo P12 on Windows with this PR here it is green:

image

guillep
guillep approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guillep guillep merged commit 9fedc93 into pharo-vcs:dev-2.0 Jan 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

@tesonep tesonep Awaiting requested review from tesonep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astares @guillep