Fix typo #1370
Closed
Fix typo #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astares
approved these changes
May 11, 2020
|
Note this PR is against "dev-1.0" branch instead of "dev-1.6". |
Should I do this change against the branch "dev-1.6" and then do a pull request? |
I've just tried to make the pull request target branch dev-1.6, but it came with lots of noise... I don't think github is smart enough to make this merge... So, yes, could you do it against 1.6? It could be merged right away. Thanks BTW! |
|
Ok, here's a link to the new pull request. Hopefully that's ok. :) |
|
We can close this one now. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed 'atttached' to 'attached'.