Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self hosted gitlab support #1021

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Conversation

gcotelli
Copy link
Contributor

@gcotelli gcotelli commented Oct 9, 2018

  • Update scpUrl and httpsUrl to support self-hosted gitlab instances (in Pharo 7)
  • Extend MCGitlabRepository for backwards compatibility with Pharo 6 (at least until Metacello is udpated in Pharo 6), it will not support self hosted gitlab instances and it will work as before.

@gcotelli
Copy link
Contributor Author

gcotelli commented Oct 9, 2018

It's related to pharo-project/pharo#1828

@gcotelli
Copy link
Contributor Author

gcotelli commented Oct 9, 2018

CI Test failures seems to be unrelated :(

@guillep
Copy link
Member

guillep commented Oct 9, 2018

I've rerun the tests (there are some hiccups from time to time).
They ran green this time.
Thanks!

@guillep guillep merged commit 07e3403 into pharo-vcs:dev-1.0 Oct 9, 2018
@guillep guillep removed the review label Oct 9, 2018
@guillep guillep added this to the 1.3 milestone Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants