Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceberg v1.2.0 breaks projects #950

Closed
jecisc opened this issue Aug 4, 2018 · 8 comments
Closed

Iceberg v1.2.0 breaks projects #950

jecisc opened this issue Aug 4, 2018 · 8 comments
Assignees
Milestone

Comments

@jecisc
Copy link
Contributor

jecisc commented Aug 4, 2018

I tried to use Iceberg v1.2.0 with MDL.

I loaded the project in my image via a Metacello script and Iceberg generated a .project and a .properties file. I committed them and now I cannot reload MDL because I get an error saying that it does not find the baseline.

MDL is a FileTree metadataless repository and I have the impression that since the commit of the files, Iceberg thinks it is a tonel repository.

Commit with the files: DuneSt/MaterialDesignLite@dfe941d

I'll revert those changes for now...

@jecisc
Copy link
Contributor Author

jecisc commented Aug 4, 2018

I have the impression that:

  • If I add the repository to Iceberg, I can use a repair action and add the format
  • If I load a project from Metacello, the .project file is generated without the format and Iceberg will consider it as a Tonel project.

@guillep
Copy link
Member

guillep commented Aug 6, 2018

I'm checking it now. It is strange because we have a large battery of tests for the metacello integration and we covered such cases

@guillep
Copy link
Member

guillep commented Aug 6, 2018

Is this the expression you used?

   Metacello new
    	githubUser: 'DuneSt' project: 'MaterialDesignLite' commitish: 'master' path: 'src';
    	baseline: 'MaterialDesignLite';
    	onWarningLog;
    	load

@jecisc
Copy link
Contributor Author

jecisc commented Aug 6, 2018

I used development, else, yes.

@guillep
Copy link
Member

guillep commented Aug 6, 2018

I cannot quite reproduce it, because when committing it's proposing me a .properties with

{
	#format : #filetree
}

image

Moreover, I've had commited and the commit looks ok.

Did you do something else?

@guillep
Copy link
Member

guillep commented Aug 6, 2018

Also, the fact that the project is loaded, it shows that even using the Metacello expression the project is correctly recognized as a filetree project.

@guillep guillep modified the milestones: 1.3, 1.2.1 Aug 6, 2018
@jecisc
Copy link
Contributor Author

jecisc commented Aug 6, 2018

This is weird... I retried and now it exports the right datas... I did it with the same image and same snippet.

What is really weird is that before it failed for all my projects: DuneSt/MaterialColors@21219e1

Now it works for all of them.

Since I don't know how to reproduce I'll close it.

@jecisc
Copy link
Contributor Author

jecisc commented Aug 6, 2018

I think I found where is the problem in what I have done.

Here is a gif showing a problem:

2018-08-06_14-12-18

I loaded the project MaterialColors via Metacello and a tag. It generated the right files. Then I wanted to commit that to the development branch. Since there is not "merge with branch" repair option, I created a new branch from the tag then I checkout the development branch. After the checkout, the file .project is fine but the .properties is empty.

@jecisc jecisc reopened this Aug 6, 2018
tesonep added a commit to tesonep/iceberg that referenced this issue Aug 6, 2018
When a properties is created it should have the default value.
@tesonep tesonep mentioned this issue Aug 6, 2018
@tesonep tesonep added review and removed in progress labels Aug 6, 2018
@guillep guillep closed this as completed Aug 6, 2018
@guillep guillep removed the review label Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants