Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo repository forgets packages #932

Closed
guillep opened this issue Jul 31, 2018 · 0 comments
Closed

Pharo repository forgets packages #932

guillep opened this issue Jul 31, 2018 · 0 comments
Assignees
Milestone

Comments

@guillep
Copy link
Member

guillep commented Jul 31, 2018

When getting a new pharo image, it comes with a pre-calculated list of pharo packages.

When cloning a pharo repository that does not contain the image commit (for example, one's own fork), the IceWorkingCopy resolves it as an UnknownCommit. Somehow, this causes iceberg also to forget all packages, and thus their dirty state.

Moreover, if we fetch and the commit is found in one remote, then the list is changed, but changes are not calculated anymore because the UnknownCommit id and the now found commit id are the same.

@guillep guillep added this to the 1.2 milestone Jul 31, 2018
@guillep guillep self-assigned this Aug 2, 2018
guillep added a commit that referenced this issue Aug 2, 2018
Fix update pharo repository in case of locating already cloned repository
@guillep guillep closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant