Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting "." in project src field gives dnu #880

Closed
macta opened this issue Jun 22, 2018 · 3 comments
Closed

Putting "." in project src field gives dnu #880

macta opened this issue Jun 22, 2018 · 3 comments
Labels
Milestone

Comments

@macta
Copy link
Contributor

macta commented Jun 22, 2018

I'm still struggling to load Calypso that isn't in a "src" directory. Thinking that if I put nothing in the src field of a project it will inherit the default value specificed in the settings - I put "." for current directory. However this gives a DNU.

UndefinedObject(Object)>>doesNotUnderstand: #nextChildNodeStartingFrom:suchThat:ifNone:
IceNode>>firstNodeSuchThat:ifNone:
IceNode>>firstNodeSuchThat:
[ tree
firstNodeSuchThat: [ :definition | self isCodeSubdirectory: definition ] ] in IceDiff>>codeSubdirectoryNode in Block: [ tree...
BlockClosure>>cull:
ByteString(Collection)>>ifNotEmpty:ifEmpty:
IceDiff>>codeSubdirectoryNode
IceDiff>>includesPackageNamed:
[ :each | each beDirty: (diff includesPackageNamed: each name) ] in IceWorkingCopy>>adoptCommit: in Block: [ :each | each beDirty: (diff includesPackageNamed...etc...
Array(SequenceableCollection)>>do:
IceWorkingCopy>>adoptCommit:
IceWorkingCopy>>initializePackagesFromRepository
IceRepositoryCreator>>cloneRepository
[ self validate.
self isCloning
ifTrue: [ self cloneRepository ]
ifFalse: [ self addLocalRepository ] ] in IceRepositoryCreator>>createRepository in Block: [ self validate....
BlockClosure>>on:do:
IceRepositoryCreator>>createRepository
[ ^ IceRepositoryCreator new
repository: repository;
remote: (IceGitRemote url: self remoteUrl);
location: self projectLocation location;
subdirectory: self subdirectoryInputText text asString trimmed;
createRepository ] in IceTipGitHubRepositoryPanel(IceTipGitRepositoryPanel)>>newRepository in Block: [ ^ IceRepositoryCreator new...
[ :bar |
bar label: aString.
aBlock value ] in MorphicUIManager(UIManager)>>informUser:during: in Block: [ :bar | ...
[ :bar | aBlock value: bar ] in MorphicUIManager>>informUserDuring: in Block: [ :bar | aBlock value: bar ]
BlockClosure>>cull:
[ ^ block cull: self ] in [ self prepareForRunning.
CurrentJob value: self during: [ ^ block cull: self ] ] in Job>>run in Block: [ ^ block cull: self ]
[ activeProcess psValueAt: index put: anObject.
aBlock value ] in CurrentJob(DynamicVariable)>>value:during: in Block: [ activeProcess psValueAt: index put: anObject....
BlockClosure>>ensure:
CurrentJob(DynamicVariable)>>value:during:
CurrentJob class(DynamicVariable class)>>value:during:
[ self prepareForRunning.
CurrentJob value: self during: [ ^ block cull: self ] ] in Job>>run in Block: [ self prepareForRunning....
BlockClosure>>ensure:
Job>>run
MorphicUIManager(UIManager)>>displayProgress:from:to:during:
MorphicUIManager>>informUserDuring:

@guillep
Copy link
Member

guillep commented Jun 26, 2018

Hi @macta , I'm working on it.

However, when you clone, if you don't specify the src directory (i.e., an empty string '') it will use the root.

@guillep guillep added this to the 1.2 milestone Jun 26, 2018
@guillep guillep added the bug label Jun 26, 2018
guillep added a commit to guillep/iceberg that referenced this issue Jun 26, 2018
guillep added a commit to guillep/iceberg that referenced this issue Jun 26, 2018
@macta
Copy link
Contributor Author

macta commented Jun 26, 2018

I added a separate issue - as I just can't seem to clone Calypso using https (and my office blocks ssh, so I can't do any lunch time experiments). I had thought it was the use of the root directory (hence how I found this minor bug).

@guillep guillep closed this as completed Jun 26, 2018
@guillep
Copy link
Member

guillep commented Jun 26, 2018

No problem. I've added ~140 more tests with a setup using a src directory and a .directory

guillep added a commit that referenced this issue Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants