Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing a PR is broken #775

Closed
jecisc opened this issue May 10, 2018 · 1 comment
Closed

Reviewing a PR is broken #775

jecisc opened this issue May 10, 2018 · 1 comment

Comments

@jecisc
Copy link
Contributor

jecisc commented May 10, 2018

OS

Windows 7

Pharo

Build information: Pharo-7.0+alpha.build.863.sha.794a5428eb0aa4d4413eb7e979f9651ec76be461 (32 Bit)

Iceberg

v0.7.5

Problem

I wanted to review this PR: pharo-project/pharo#1331

I opened the PR View windows of the Pharo repository, selected the one from sven and tried to review.

I only got an empty window.

image

@bencoman
Copy link

bencoman commented Sep 9, 2018

Windows 10, Pharo: 6.1...
Downloaded http://files.pharo.org/platform/Pharo6.1-win.zip
Updated Icerberg per https://github.com/pharo-vcs/iceberg#update-iceberg
Iceberg

Settings > Use custom keys = Enabled
Add > Clone remote repository
Remote URL = [hidden email]:exercism/pharo.git
==> "pharo" repo appears, status "Not loaded"
"pharo" repo > Packages ==> BaselineOfExercism, Exercism, etc
"pharo" repo > Github > View pull request > origin > enter github account password
==> shows PR#98 "Move setup to class initialization..."
> right-click 98 > Review pull request
==> an empty window titled "Browsing pull request: #98...." appeared...
a03-empty-pull-request-review

@guillep guillep added this to the 1.3 milestone Oct 31, 2018
@guillep guillep closed this as completed Oct 31, 2018
@guillep guillep removed the review label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants