Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP remote type #1260

Closed
gcotelli opened this issue Jun 25, 2019 · 3 comments
Closed

HTTP remote type #1260

gcotelli opened this issue Jun 25, 2019 · 3 comments

Comments

@gcotelli
Copy link
Contributor

Sometimes you want to access a remote using plain HTTP and not HTTPS, for example for self-hosted instances.
In that case you need something like a HTTP remote type.

@gcotelli
Copy link
Contributor Author

The changes should be pretty straighforward:

MCGitBasedNetworkRepository>>#httpUrl
	^ self httpsUrl copyReplaceAll: 'https://' with: 'http://'
MCGitBasedNetworkRepository>>#httpsUrl
       self subclassResponsibility

and changing Iceberg class>>#settingsOn: to include ('HTTP (http://github.com/<username>/<project>.git)' -> #httpUrl) as an option in the array.

I couldn't figure out how to use Iceberg to contribute to Iceberg. The Pharo 8 version is showing a lot of deprecation warnings and I cannot update the Pharo 7 version to the latests dev branch.

@astares
Copy link
Contributor

astares commented Jun 26, 2019

@gc# The deprecations are due to Spec transition. You can just ignore them.

It would be good to open an issue on Iceberg repo for this (https://github.com/pharo-vcs/iceberg)

@guillep
Copy link
Member

guillep commented Jun 15, 2020

Fixed upstream

@guillep guillep closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants