Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving a class between packages not properly catched #1106

Closed
astares opened this issue Dec 16, 2018 · 2 comments
Closed

Moving a class between packages not properly catched #1106

astares opened this issue Dec 16, 2018 · 2 comments
Labels
bug easy
Milestone
v1.5.0

Comments

@astares
Copy link
Contributor

astares commented Dec 16, 2018

Scenario:

  • Pharo 7.0.0 Build information: Pharo-7.0.0+rc1.build.49.sha.389dabb14e2e02521407af34098afeab9772d903 (64 Bit)

  • I move the class FileDoesNotExist from "FileSystem-Core" to "Deprecated70-FileSystem" by dragging it from one calypso browser to the other

  • when I look in Iceberg for the change to commit I only see a single modification in package
    "Deprecated70" (the addition of the class there) but no modification in package "FileSystem-Core"
    as removal
@astares
Copy link
Contributor Author

astares commented Dec 16, 2018

Pharo bug

https://pharo.fogbugz.com/f/cases/22798/Moving-a-class-between-packages-not-properly-catched

@guillep
Copy link
Member

guillep commented Dec 18, 2018

It looks like a problem in how the class repackaged announcement is interpreted

@guillep guillep added this to the v1.4.2 milestone Dec 18, 2018
guillep added a commit to guillep/iceberg that referenced this issue Dec 18, 2018
@guillep
Fix issue pharo-vcs#1106
fcf83e2 
Correctly ask the announcement for the affected packages and not to the class.
@guillep guillep mentioned this issue Dec 18, 2018
Merged
@guillep guillep closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
2 participants
@guillep @astares