Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pharo 7: PackageManifest subclasses should be packaged with "Manifest" tag #1066

Closed
astares opened this issue Nov 5, 2018 · 1 comment
Closed

Pharo 7: PackageManifest subclasses should be packaged with "Manifest" tag #1066

astares opened this issue Nov 5, 2018 · 1 comment
Labels
enhancement
Milestone
1.4.0

Comments

@astares
Copy link
Contributor

astares commented Nov 5, 2018

Can you please put all the Manifests of Iceberg and Libgit into an own tag "Manifest" like in most Pharo packages so we also have more clean Iceberg packages?

See https://pharo.fogbugz.com/f/cases/22436/PackageManifest-subclasses-should-be-packaged-with-Manifest-tag and subcases for details.

For Iceberg this is:
ManifestLibGitCore
ManifestIceberg
ManifestIcebergMetacelloIntegration
ManifestIcebergPlugin
ManifestIcebergPluginGitHub
ManifestIcebergLibgit
ManifestIcebergLibgitFiletree
ManifestIcebergLibgitTonel
@astares
Copy link
Contributor Author

astares commented Nov 5, 2018

Pharo bug is https://pharo.fogbugz.com/f/cases/22630/

guillep added a commit that referenced this issue Nov 5, 2018
@guillep
Fix #1066
faf780c 
Add Manifest tag to manifests

https://pharo.fogbugz.com/f/cases/22630/
https://pharo.fogbugz.com/f/cases/22436/PackageManifest-subclasses-should-be-packaged-with-Manifest-tag
@guillep guillep added this to the 1.4.0 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@guillep @astares