Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean useless huge hierarchy in Github plugin UI #1051

Closed
jecisc opened this issue Oct 30, 2018 · 2 comments
Closed

Clean useless huge hierarchy in Github plugin UI #1051

jecisc opened this issue Oct 30, 2018 · 2 comments
Milestone
1.3

Comments

@jecisc
Copy link
Contributor

jecisc commented Oct 30, 2018

It is not referenced. I added a halt inside the building and played with Iceberg. I got no debugger.
@jecisc
Copy link
Contributor Author

jecisc commented Oct 30, 2018

Oh, apparently it has a subclass that is used.

@guillep
Copy link
Member

guillep commented Oct 30, 2018 via email

@jecisc jecisc changed the title IceBranchBrowser seems like dead code Clean useless huge hierarchy in Github plugin UI Oct 30, 2018
jecisc added a commit to jecisc/iceberg that referenced this issue Oct 30, 2018
@jecisc
Remove dead code and useless huge hierarchy.
6dea210 
Fixes pharo-vcs#1051
@jecisc jecisc mentioned this issue Oct 30, 2018
Merged
@guillep guillep added this to the 1.3 milestone Oct 30, 2018
@guillep guillep closed this as completed Oct 30, 2018
@guillep guillep removed the review label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
3 participants
@estebanlm @guillep @jecisc