Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for binary files #1030

Closed
guillep opened this issue Oct 17, 2018 · 0 comments
Closed

Better support for binary files #1030

guillep opened this issue Oct 17, 2018 · 0 comments
Milestone
1.3

Comments

@guillep
Copy link
Member

guillep commented Oct 17, 2018

Right now, when merging or showing diffs of binary files, an exception most probably will be shown.

  • we should handle it more gracefully on the UI
  • merge should still work correctly
@guillep guillep added this to the 1.3 milestone Oct 17, 2018
guillep added a commit that referenced this issue Oct 17, 2018
@guillep
Fix #1030
7fb9dce 
 - add support to display hex dumps of binary files in IceFileDefinition
 - fix GitWorkingCopyUpdater to correctly write only binary contents
 - Fix IceTipDiffPanel so it does first clean the diff before updating it (when clicking back and forth between different files in the diff)
 - add tests
@guillep guillep closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@guillep