Clean packages usage

- Remove dead #classCategory (we do not want categories anymore!) - Replace references to RPackageOrganizer for PackageOrganizer - Remove usage of RPackageSet. Monticello does not use the cache anymore! So we can remove everything about it (especially since RPackageSet will be deprecated)
pharo-vcs · Nov 16, 2023 · cbdf20d · cbdf20d
1 parent 622e4bb
commit cbdf20d
Show file tree

Hide file tree

Showing 295 changed files with 3,185 additions and 2,752 deletions.
diff --git a/.github/scripts/preLoading.st b/.github/scripts/preLoading.st
@@ -1,3 +1,3 @@
 #( 'BaselineOfLibGit' 'BaselineOfIceberg' ) do: [ :each | 
-	(RPackageOrganizer default packageNamed: each ifAbsent: [ nil ]) 
+	(PackageOrganizer default packageNamed: each ifAbsent: [ nil ]) 
 		ifNotNil: [ :aPackage | aPackage removeFromSystem ] ]
diff --git a/Iceberg-Tests/IceSinglePackageLocalRepositoryTest.class.st b/Iceberg-Tests/IceSinglePackageLocalRepositoryTest.class.st
@@ -430,7 +430,7 @@ IceSinglePackageLocalRepositoryTest >> testCheckoutCodeRepositoryInstallsCodeInI
 	self repository commitWithMessage: message.
 
 	self repository unload.
-	self deny: (RPackageOrganizer default includesPackageNamed: self packageName1).
+	self deny: (PackageOrganizer default includesPackageNamed: self packageName1).
 
 	self repository head checkoutAllPackages.
 	self assertClassExists: #IceGeneratedClassForTesting.
@@ -458,7 +458,7 @@ IceSinglePackageLocalRepositoryTest >> testCheckoutCommitInstallsCodeInImage [
 	self repository commitWithMessage: message.
 
 	self repository unload.
-	self deny: (RPackageOrganizer default includesPackageNamed: self packageName1).
+	self deny: (PackageOrganizer default includesPackageNamed: self packageName1).
 
 	self repository branch commit checkoutAllPackages.
 	self assertClassExists: #IceGeneratedClassForTesting.

diff --git a/Iceberg-TipUI/Clipboard.extension.st b/Iceberg-TipUI/Clipboard.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #Clipboard }
+Extension { #name : 'Clipboard' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 Clipboard class >> clipboardText: aText informing: aString [
 	UIManager inform: aString.
 	^ self clipboardText: aText

diff --git a/Iceberg-TipUI/CmCommandGroup.extension.st b/Iceberg-TipUI/CmCommandGroup.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #CmCommandGroup }
+Extension { #name : 'CmCommandGroup' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 CmCommandGroup >> commandOrGroupNamed: aString ifFound: aBlock [
 
 	^ entries

diff --git a/Iceberg-TipUI/CmCommandGroupDecorator.extension.st b/Iceberg-TipUI/CmCommandGroupDecorator.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #CmCommandGroupDecorator }
+Extension { #name : 'CmCommandGroupDecorator' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 CmCommandGroupDecorator >> commandOrGroupNamed: aString ifFound: aBlock [
 
 	^ self decoratedGroup commandOrGroupNamed: aString ifFound: aBlock

diff --git a/Iceberg-TipUI/CmUICommandDisplayStrategy.extension.st b/Iceberg-TipUI/CmUICommandDisplayStrategy.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #CmUICommandDisplayStrategy }
+Extension { #name : 'CmUICommandDisplayStrategy' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 CmUICommandDisplayStrategy >> ifVisible: aCmSpecCommand do: aBlock [
 
 	self subclassResponsibility

diff --git a/Iceberg-TipUI/CmUIDisableWhenCantBeRun.extension.st b/Iceberg-TipUI/CmUIDisableWhenCantBeRun.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #CmUIDisableWhenCantBeRun }
+Extension { #name : 'CmUIDisableWhenCantBeRun' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 CmUIDisableWhenCantBeRun >> ifVisible: aCmSpecCommand do: aBlock [
 	"Always visible"
 

diff --git a/Iceberg-TipUI/CmUIHideWhenCantBeRun.extension.st b/Iceberg-TipUI/CmUIHideWhenCantBeRun.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #CmUIHideWhenCantBeRun }
+Extension { #name : 'CmUIHideWhenCantBeRun' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 CmUIHideWhenCantBeRun >> ifVisible: aCmSpecCommand do: aBlock [
 	"Visible if #canBeExecuted"
 

diff --git a/Iceberg-TipUI/FTBasicItem.extension.st b/Iceberg-TipUI/FTBasicItem.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #FTBasicItem }
+Extension { #name : 'FTBasicItem' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 FTBasicItem >> toggle [
 	self isExpanded
 		ifTrue: [ self collapseAndRefresh ]

diff --git a/Iceberg-TipUI/FTRootItem.extension.st b/Iceberg-TipUI/FTRootItem.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #FTRootItem }
+Extension { #name : 'FTRootItem' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 FTRootItem >> isRoot [
 	^ true
 ]
diff --git a/Iceberg-TipUI/FTTableMorph.extension.st b/Iceberg-TipUI/FTTableMorph.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #FTTableMorph }
+Extension { #name : 'FTTableMorph' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 FTTableMorph >> selectFirstVisibleRow [
 	^ self
 		selectIndex:
@@ -9,7 +9,7 @@ FTTableMorph >> selectFirstVisibleRow [
 				ifEmpty: [ 0 ])
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 FTTableMorph >> useFunction: aFilterFunctionClass do: aBlock [ 
 	function := aFilterFunctionClass table: self.
 	aBlock cull: function cull: self

diff --git a/Iceberg-TipUI/FTTreeItem.extension.st b/Iceberg-TipUI/FTTreeItem.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #FTTreeItem }
+Extension { #name : 'FTTreeItem' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 FTTreeItem >> isRoot [
 	^ false
 ]
diff --git a/Iceberg-TipUI/IceAbstractCredentials.extension.st b/Iceberg-TipUI/IceAbstractCredentials.extension.st
@@ -1,11 +1,11 @@
-Extension { #name : #IceAbstractCredentials }
+Extension { #name : 'IceAbstractCredentials' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceAbstractCredentials >> askForModelClass [
 	^ self subclassResponsibility
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceAbstractCredentials >> editModelClass [
 	^ self subclassResponsibility
 ]
diff --git a/Iceberg-TipUI/IceAddition.extension.st b/Iceberg-TipUI/IceAddition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceAddition }
+Extension { #name : 'IceAddition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceAddition >> icon [
 
 	^ self iconNamed: #changeAdd

diff --git a/Iceberg-TipUI/IceCheckoutAllPackages.extension.st b/Iceberg-TipUI/IceCheckoutAllPackages.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceCheckoutAllPackages }
+Extension { #name : 'IceCheckoutAllPackages' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceCheckoutAllPackages class >> description [
 	^ 'Checkout ALL packages in the repository'
 ]
diff --git a/Iceberg-TipUI/IceCheckoutAlreadyLoadedPackages.extension.st b/Iceberg-TipUI/IceCheckoutAlreadyLoadedPackages.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceCheckoutAlreadyLoadedPackages }
+Extension { #name : 'IceCheckoutAlreadyLoadedPackages' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceCheckoutAlreadyLoadedPackages class >> description [
 	^ 'Checkout packages ALREADY LOADED in the image'
 ]
diff --git a/Iceberg-TipUI/IceCheckoutDoNotLoadPackages.extension.st b/Iceberg-TipUI/IceCheckoutDoNotLoadPackages.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceCheckoutDoNotLoadPackages }
+Extension { #name : 'IceCheckoutDoNotLoadPackages' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceCheckoutDoNotLoadPackages class >> description [
 	^ 'DO NOT CHECKOUT any packages, I will load them manually (for experts only)'
 ]
diff --git a/Iceberg-TipUI/IceCheckoutStrategy.extension.st b/Iceberg-TipUI/IceCheckoutStrategy.extension.st
@@ -1,12 +1,12 @@
-Extension { #name : #IceCheckoutStrategy }
+Extension { #name : 'IceCheckoutStrategy' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceCheckoutStrategy >> description [
 
 	^ self class description
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceCheckoutStrategy class >> description [
 	^ self subclassResponsibility
 ]
diff --git a/Iceberg-TipUI/IceClassDefinition.extension.st b/Iceberg-TipUI/IceClassDefinition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceClassDefinition }
+Extension { #name : 'IceClassDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceClassDefinition >> icon [
 	^ self iconNamed: #class
 ]
diff --git a/Iceberg-TipUI/IceConflictingOperation.extension.st b/Iceberg-TipUI/IceConflictingOperation.extension.st
@@ -1,11 +1,11 @@
-Extension { #name : #IceConflictingOperation }
+Extension { #name : 'IceConflictingOperation' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceConflictingOperation >> operationIcon [
 	^ self iconNamed: #changeUpdate
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceConflictingOperation >> preferredColor [
 
 	^ self isResolved

diff --git a/Iceberg-TipUI/IceCreateBranchCommand.class.st b/Iceberg-TipUI/IceCreateBranchCommand.class.st
@@ -3,12 +3,14 @@ I'm a command to create a new branch from a commit.
 this is usefull in the case of commiting changes in unsync repositories (so you open a branch and you commit there)
 "
 Class {
-	#name : #IceCreateBranchCommand,
-	#superclass : #IceRepositoryCommand,
-	#category : #'Iceberg-TipUI-Commands'
+	#name : 'IceCreateBranchCommand',
+	#superclass : 'IceRepositoryCommand',
+	#category : 'Iceberg-TipUI-Commands',
+	#package : 'Iceberg-TipUI',
+	#tag : 'Commands'
 }
 
-{ #category : #execute }
+{ #category : 'execute' }
 IceCreateBranchCommand >> execute [
 	| selection |
 

diff --git a/Iceberg-TipUI/IceDefinition.extension.st b/Iceberg-TipUI/IceDefinition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceDefinition }
+Extension { #name : 'IceDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceDefinition >> icon [
 
 	self subclassResponsibility

diff --git a/Iceberg-TipUI/IceDirectoryDefinition.extension.st b/Iceberg-TipUI/IceDirectoryDefinition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceDirectoryDefinition }
+Extension { #name : 'IceDirectoryDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceDirectoryDefinition >> icon [
 	^ self iconNamed: #emptyPackage
 ]
diff --git a/Iceberg-TipUI/IceErrorVisitor.extension.st b/Iceberg-TipUI/IceErrorVisitor.extension.st
@@ -1,13 +1,13 @@
-Extension { #name : #IceErrorVisitor }
+Extension { #name : 'IceErrorVisitor' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceErrorVisitor >> visitExperimentalFeature: aWarning [
 
 	"By default experimental features are just accepted when we are not in an interactive mode".
 	aWarning resume
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceErrorVisitor >> visitNoCommitMessage: aWarning [
 	self visitGenericError: aWarning
 ]
diff --git a/Iceberg-TipUI/IceExperimentalFeature.class.st b/Iceberg-TipUI/IceExperimentalFeature.class.st
@@ -4,12 +4,14 @@ Everytime an user tries to use an experimental feature, maybe the UI want to sho
 This is useful to guarantee the correct keeping of the changes.
 "
 Class {
-	#name : #IceExperimentalFeature,
-	#superclass : #IceWarning,
-	#category : #'Iceberg-TipUI-Exceptions'
+	#name : 'IceExperimentalFeature',
+	#superclass : 'IceWarning',
+	#category : 'Iceberg-TipUI-Exceptions',
+	#package : 'Iceberg-TipUI',
+	#tag : 'Exceptions'
 }
 
-{ #category : #visiting }
+{ #category : 'visiting' }
 IceExperimentalFeature >> acceptError: aVisitor [
 
 	aVisitor visitExperimentalFeature: self

diff --git a/Iceberg-TipUI/IceExtensionDefinition.extension.st b/Iceberg-TipUI/IceExtensionDefinition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceExtensionDefinition }
+Extension { #name : 'IceExtensionDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceExtensionDefinition >> icon [
 	^ self iconNamed: #group
 ]
diff --git a/Iceberg-TipUI/IceFileDefinition.extension.st b/Iceberg-TipUI/IceFileDefinition.extension.st
@@ -1,6 +1,6 @@
-Extension { #name : #IceFileDefinition }
+Extension { #name : 'IceFileDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceFileDefinition >> icon [
 	^ self iconNamed: #book
 ]
diff --git a/Iceberg-TipUI/IceFileSystemDefinition.extension.st b/Iceberg-TipUI/IceFileSystemDefinition.extension.st
@@ -1,13 +1,13 @@
-Extension { #name : #IceFileSystemDefinition }
+Extension { #name : 'IceFileSystemDefinition' }
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceFileSystemDefinition >> canBeBrowsed [
 
 	"It can always be browsed through the libgit file system"
 	^ true
 ]
 
-{ #category : #'*Iceberg-TipUI' }
+{ #category : '*Iceberg-TipUI' }
 IceFileSystemDefinition >> canBrowseReferences [
 
 	"We do not track file references..."