Merge pull request #1752 from astares/1751-Use-isNotEmpty-instead-of-…

…notEmpty-in-Iceberg Use #isNotEmpty instead of #notEmpty in Iceberg
pharo-vcs · Nov 21, 2023 · 2e64076 · 2e64076
2 parents 97582ee + 6b01b44
commit 2e64076
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 18 deletions.
diff --git a/Iceberg-Libgit/IceRepositoryCreator.class.st b/Iceberg-Libgit/IceRepositoryCreator.class.st
@@ -34,7 +34,7 @@ IceRepositoryCreator class >> defaultSubdirectory [
 IceRepositoryCreator class >> isGitRoot: aReference [
 	self flag: #pharoTodo. "This does not understand submodules"
 	^ aReference isDirectory 
-		and: [ (aReference directoriesMatching: '.git') notEmpty
+		and: [ (aReference directoriesMatching: '.git') isNotEmpty
 		and: [ (aReference / '.git' / 'config') exists ] ]
 ]
 

diff --git a/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st b/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st
@@ -180,7 +180,7 @@ IceGitHubNewBranchFromIssuePanel >> useRemote: aRemoteModel [
 IceGitHubNewBranchFromIssuePanel >> validate [
 
 	self
-		assert: ((issueNumberText text asString notEmpty) and: [ issueNumberText text isAllDigits ])
+		assert: ((issueNumberText text asString isNotEmpty) and: [ issueNumberText text isAllDigits ])
 		description: 'Please enter a valid issue number'.
 	self
 		assert: fetched

diff --git a/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st b/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st
@@ -142,10 +142,10 @@ IceTipAddRemoteDialogPresenter >> urlText [
 IceTipAddRemoteDialogPresenter >> validate [
 
 	self
-		assert: self remoteName notEmpty 
+		assert: self remoteName isNotEmpty 
 		description: 'You need to specify a remote name.'.
 	self
-		assert: self remoteUrl notEmpty
+		assert: self remoteUrl isNotEmpty
 		description: 'You need to specify a remote url.'
 
 ]
diff --git a/Iceberg-TipUI/IceTipMergeSelectingPanel.class.st b/Iceberg-TipUI/IceTipMergeSelectingPanel.class.st
@@ -28,13 +28,13 @@ IceTipMergeSelectingPanel >> changeListColumn [
 				onActivation: [ :iceNode |
 					checkedIceNodes add: iceNode.
 					iceNode value selectLeft.
-					iceNode notEmpty ifTrue: [
+					iceNode isNotEmpty ifTrue: [
 						iceNode allChildrenDo: [ :child | checkedIceNodes add: child ].
 						self basicRefresh ] ];
 				onDeactivation: [ :iceNode |
 					checkedIceNodes remove: iceNode.
 					iceNode value selectRight.
-					iceNode notEmpty ifTrue: [
+					iceNode isNotEmpty ifTrue: [
 						iceNode allChildrenDo: [ :child |
 							checkedIceNodes remove: child ifAbsent: [  ] ].
 						self basicRefresh ].

diff --git a/Iceberg-TipUI/IceTipRepositoryModel.class.st b/Iceberg-TipUI/IceTipRepositoryModel.class.st
@@ -129,7 +129,7 @@ IceTipRepositoryModel >> descriptionDecorator [
 
 { #category : 'testing' }
 IceTipRepositoryModel >> hasRemotes [
-	^ self entity remotes notEmpty
+	^ self entity remotes isNotEmpty
 ]
 
 { #category : 'testing' }
@@ -187,7 +187,7 @@ IceTipRepositoryModel >> isLibGitAvailable [
 
 { #category : 'private - testing' }
 IceTipRepositoryModel >> isLoaded [
-	^ self entity loadedPackages notEmpty 
+	^ self entity loadedPackages isNotEmpty 
 ]
 
 { #category : 'testing' }
@@ -441,7 +441,7 @@ IceTipRepositoryModel >> status [
 			ifTrue: [ ^ entity workingCopy workingCopyState description ].	
 		entity workingCopy isDetached 
 			ifTrue: [  ^ 'Detached Working Copy' ].
-		(entity head isDetached and: [ entity head tags notEmpty ])
+		(entity head isDetached and: [ entity head tags isNotEmpty ])
 			ifTrue: [ ^ 'Detached HEAD' ].
 		entity head isDetached 
 			ifTrue: [ ^ 'Detached HEAD' ].
@@ -477,7 +477,7 @@ IceTipRepositoryModel >> statusDecorator [
 			ifTrue: [ ^ IceTipStatusDecorator error ].	
 		entity workingCopy isDetached 
 			ifTrue: [  ^ IceTipStatusDecorator error ].
-		(entity head isDetached and: [ entity head tags notEmpty ])
+		(entity head isDetached and: [ entity head tags isNotEmpty ])
 			ifTrue: [ ^ IceTipStatusDecorator warning ].
 		entity head isDetached 
 			ifTrue: [ ^ IceTipStatusDecorator error ].
@@ -501,7 +501,7 @@ IceTipRepositoryModel >> statusString [
 			ifTrue: [ ^ entity workingCopy workingCopyState description ].	
 		entity workingCopy isDetached 
 			ifTrue: [  ^ 'Detached Working Copy' ].
-		(entity head isDetached and: [ entity head tags notEmpty ])
+		(entity head isDetached and: [ entity head tags isNotEmpty ])
 			ifTrue: [ ^ 'Detached HEAD' ].
 		entity head isDetached 
 			ifTrue: [ ^ 'Detached HEAD' ].

diff --git a/Iceberg-TipUI/IceTipSelectAllPackagesCommand.class.st b/Iceberg-TipUI/IceTipSelectAllPackagesCommand.class.st
@@ -29,7 +29,7 @@ IceTipSelectAllPackagesCommand >> canBeExecuted [
 	| pkgList |
 
 	pkgList := self packagesList.
- 	^ pkgList items notEmpty and: [ pkgList items size ~= pkgList selectedItems size ]
+ 	^ pkgList items isNotEmpty and: [ pkgList items size ~= pkgList selectedItems size ]
 ]
 
 { #category : 'executing' }

diff --git a/Iceberg-TipUI/IceTipUnselectAllPackagesCommand.class.st b/Iceberg-TipUI/IceTipUnselectAllPackagesCommand.class.st
@@ -29,7 +29,7 @@ IceTipUnselectAllPackagesCommand >> canBeExecuted [
 	| pkgList |
 
 	pkgList := self context packagesList.
- 	^ pkgList items notEmpty
+ 	^ pkgList items isNotEmpty
 ]
 
 { #category : 'executing' }

diff --git a/Iceberg/IceRepository.class.st b/Iceberg/IceRepository.class.st
@@ -507,7 +507,7 @@ IceRepository >> hasIncomingCommitsFrom: aRemote [
 
 { #category : 'testing' }
 IceRepository >> hasLoadedPackages [
-	^ self loadedPackages notEmpty
+	^ self loadedPackages isNotEmpty
 ]
 
 { #category : 'API - branches' }

diff --git a/Iceberg/IceSshCredentials.class.st b/Iceberg/IceSshCredentials.class.st
@@ -51,9 +51,9 @@ IceSshCredentials >> isDefault [
 
 { #category : 'testing' }
 IceSshCredentials >> isPresent [
-	^ self username notEmpty 
-		and: [ self publicKey notEmpty 
-		and: [ self privateKey notEmpty ] ]
+	^ self username isNotEmpty 
+		and: [ self publicKey isNotEmpty 
+		and: [ self privateKey isNotEmpty ] ]
 ]
 
 { #category : 'accessing' }

diff --git a/Iceberg/IceTokenCredentials.class.st b/Iceberg/IceTokenCredentials.class.st
@@ -31,7 +31,7 @@ IceTokenCredentials >> hostDescription [
 
 { #category : 'accessing' }
 IceTokenCredentials >> isPresent [
-	^ self token notEmpty
+	^ self token isNotEmpty
 ]
 
 { #category : 'accessing' }