Fixes the issue 1861 on Pharo

pharo-vcs · Nov 25, 2024 · 2d5a2c1 · 2d5a2c1
1 parent f68d6a9
commit 2d5a2c1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/Iceberg-TipUI/IceTipLocalRepositoryPanel.class.st b/Iceberg-TipUI/IceTipLocalRepositoryPanel.class.st
@@ -90,7 +90,5 @@ IceTipLocalRepositoryPanel >> validate [
 	self
 		assert: self location exists
 		description: 'Project location must exist!'.
-	self
-		assert: (IceRepositoryCreator isGitRoot: self location)
-		description: 'Project location does not seems to be a valid git repository.'
+
 ]
diff --git a/Iceberg-TipUI/IceTipOptionDialogPresenter.class.st b/Iceberg-TipUI/IceTipOptionDialogPresenter.class.st
@@ -22,12 +22,22 @@ Class {
 { #category : 'actions' }
 IceTipOptionDialogPresenter >> accept [
 
-	[ 
-	  self doAccept.
-	  self closeWindow ]
-		  on: IceError , IceWarning
-		  do: [ :e | 
-			  e acceptError: (IceTipInteractiveErrorVisitor newContext: self) ]
+	[
+	self selectedType class = IceTipLocalRepositoryPanel
+		ifTrue: [
+			(IceRepositoryCreator isGitRoot: self selectedType location)
+				ifFalse: [
+					self inform: ('"{1}" git repository not found' format:
+							 { self selectedType location fullName }) ]
+				ifTrue: [
+					self doAccept.
+					self closeWindow ] ]
+		ifFalse: [
+			self doAccept.
+			self closeWindow ] ]
+		on: IceError , IceWarning
+		do: [ :e |
+			e acceptError: (IceTipInteractiveErrorVisitor newContext: self) ]
 ]
 
 { #category : 'accessing' }